From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 43CF83858438 for ; Mon, 18 Jul 2022 14:01:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 43CF83858438 Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-422-6qjZqND7PZqoRBCoY1WBbg-1; Mon, 18 Jul 2022 10:01:24 -0400 X-MC-Unique: 6qjZqND7PZqoRBCoY1WBbg-1 Received: by mail-qk1-f199.google.com with SMTP id ay35-20020a05620a17a300b006b5d9646d31so5502593qkb.6 for ; Mon, 18 Jul 2022 07:01:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=EqKRctSIhkZI9jRpLw5FgdYDOn4xxurrhESmCzI997k=; b=i7tGrL+yUnDAqMUCl+dE0XPChhjU5Osoe+I+PAMUa3n+yx8Kt+QgtjpETNEOO8EngX uyRRfkmaR1KRq1x3aR2Z8tQ+afRX2tLeIaIHeiWd8o5m995Ahb60MvkW2K4z0jdcKZEb 3wvzUzwvc3ktCGAkHLFg30hwSXkg/33D90Deh3xF3GkGk/XukMH7ckfWB+p1BO14KZpE zdh5qx7vFuwGHMBxs6YvhCjBTswiAW+EqeDAjWIs0hJFg8BIG5CCSh0pto0sWpFhckYn VmTedh7bMjuwVYYa1/krnYuRs2XANnSrj9qbR88/0YrV0TWSeXk0Y2DLdwigTJBFZFTs qG1A== X-Gm-Message-State: AJIora+GaIBoOldBMZmyd3zX8zkX49at23phdcAZHz20bCVYS1mj0MxJ p5fFdjKBB792nt0COW5QLwBMAIInaLjM2T3ROSs5LCOYAL1osfhFm0CqJhYSvE89ia2pRQ9/qB4 d8ic06p+xV8lmNqD1e0lc X-Received: by 2002:a05:6214:1c83:b0:46b:a79a:2f0b with SMTP id ib3-20020a0562141c8300b0046ba79a2f0bmr21268120qvb.103.1658152883445; Mon, 18 Jul 2022 07:01:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uIIiug+KB8jz3GbhGQklR/DrhJn0wWySNLEzq8Ib2B6SFnwmfzyF44KD2exwb2gzE39Q2fVA== X-Received: by 2002:a05:6214:1c83:b0:46b:a79a:2f0b with SMTP id ib3-20020a0562141c8300b0046ba79a2f0bmr21268086qvb.103.1658152883177; Mon, 18 Jul 2022 07:01:23 -0700 (PDT) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id h24-20020ac85158000000b003051ea4e7f6sm9179799qtn.48.2022.07.18.07.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 07:01:22 -0700 (PDT) Message-ID: Date: Mon, 18 Jul 2022 10:01:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] elf.h: Add ELFCOMPRESS_ZSTD To: Florian Weimer , Fangrui Song via Libc-alpha Cc: Cary Coutant References: <20220708233233.2554110-1-maskray@google.com> <871qus8cuw.fsf@oldenburg.str.redhat.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <871qus8cuw.fsf@oldenburg.str.redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2022 14:01:26 -0000 On 7/11/22 00:58, Florian Weimer via Libc-alpha wrote: > * Fangrui Song via Libc-alpha: > >> I wish that the macro definition can catch up the upcoming >> https://sourceware.org/glibc/wiki/Release/2.36 [1], so that >> projects can expect the value ELFCOMPRESS_ZSTD from elf.h. >> The projects may choose to define the macro themselves, >> but having the definition in an earlier release seems a good idea >> anyway, and it the glibc definition makes it clearer ELFCOMPRESS_ZSTD >> is standard and vendors can start adding support. >> >> [1]: https://sourceware.org/pipermail/libc-alpha/2022-July/140352.html >> ("Release of glibc 2.36 in 1 month! Please add blockers and desirable for release.") > > This looks quite backportable to me, so it should not be a release > blocker. It's only a blocker if we apply the patch today, then we'd > have to wait until the gABI assignment actually happens as expected. Agreed. This is a NACK from me as the RM until the gABI assignment happens. -- Cheers, Carlos.