Re: [hurd,commited] hurd: Fix build ot misc/tst-preadvwritev2-common.c

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 04/09/2017 11:06, Florian Weimer wrote:
> On 09/04/2017 04:04 PM, Adhemerval Zanella wrote:
>>
>>
>> On 04/09/2017 10:40, Florian Weimer wrote:
>>> On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:
>>>>
>>>>
>>>> On 04/09/2017 05:11, Florian Weimer wrote:
>>>>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:
>>>>>> +	* misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,
>>>>>> +	RWF_NOWAIT): Define to 0 if undefined already.
>>>>>> +	(do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED
>>>>>> +	boils down to 0.
>>>>>
>>>>> I don't think this is correct.  preadv2 etc. are supposed to be part of
>>>>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,
>>>>> that's a real bug.
>>>>
>>>> I agree and the default implementation on sysdeps/posix/preadv2.c (which
>>>> I think it is also the default of hurd) will fail for any flag different
>>>> than 0. Should we add a note on manual the current flags are Linux only?
>>>
>>> I would have expected that we'd add the flags to the generic API.
>>
>> I meant that the flags only really *work* on Linux.
> 
> Yes, I think that would be fine.

Ok, I will work on that patch.