From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) by sourceware.org (Postfix) with ESMTPS id D9CCA3858403 for ; Fri, 10 Dec 2021 14:41:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D9CCA3858403 Received: by mail-qk1-x729.google.com with SMTP id 132so7841187qkj.11 for ; Fri, 10 Dec 2021 06:41:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cjFp2p4ZXMGgN+cJVF+XpMzN2I6VGy1BSryOFddaQPo=; b=Z8Zd12plRWetZnY8M0Y7vCRoYzcuacrcSB2GSdeY86h2xrzXErk92/SMKrLtAWy5uq XC5m6iLJpAXt227K6PFe13JjZjC7I85jR0HaBsdv3whVQMBX9Xgv8Nx1++R115ZodPjG i7IcR+kunNs+BdZ48G5mBthkykGsrLlipoX/bAgvRTBRT2UQhk6/Rw6FQ9JaUyQ9eP8N 16rD+aWYoGXLyoeoUQcOQHL41xMq0o4u1ZVwkBzdATTIwe5n/T0pqgCeQUWk62VgXSYN jH1WhZfQyyEoD8496hwV1tUxyDkCO58PL339QsvX9DZ8XwFTfWFrPe87vBTXOwPekDY7 IACw== X-Gm-Message-State: AOAM5320uy9pjAzxhC7NOKWug8DtuFFDCuTCANT6+PU0F7mMVXoe7HG/ tZNjGVkS+DA7Q21cYAfhczYyag== X-Google-Smtp-Source: ABdhPJzxiqdT1EGWXboforwBWH3pWkQSu5T3jMyQsU66DxqysAkb3JjypayzUldrwmGMwXG5hHL7bw== X-Received: by 2002:a05:620a:2955:: with SMTP id n21mr20357439qkp.581.1639147267481; Fri, 10 Dec 2021 06:41:07 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a776:ce11:d591:8bd5:613f? ([2804:431:c7ca:a776:ce11:d591:8bd5:613f]) by smtp.gmail.com with ESMTPSA id y11sm2174012qta.6.2021.12.10.06.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 06:41:07 -0800 (PST) Message-ID: Date: Fri, 10 Dec 2021 11:41:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v6 02/20] elf: Add _dl_audit_objopen Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-3-adhemerval.zanella@linaro.org> <87ee6kaazs.fsf@oldenburg.str.redhat.com> <87a6h8aamt.fsf@oldenburg.str.redhat.com> <9bc38147-433c-a915-1ba9-e8d730a1d728@linaro.org> <285481b2-2621-1c61-07e8-1964e6be7a8f@linaro.org> <874k7g8s15.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <874k7g8s15.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 14:41:09 -0000 On 10/12/2021 11:15, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 10/12/2021 10:45, Adhemerval Zanella wrote: >>> >>> >>> On 10/12/2021 09:48, Florian Weimer wrote: >>>> * Florian Weimer: >>>> >>>>> * Adhemerval Zanella: >>>>> >>>>>> diff --git a/elf/Makefile b/elf/Makefile >>>>>> index 8f3e3a3602..80ed31edbe 100644 >>>>>> --- a/elf/Makefile >>>>>> +++ b/elf/Makefile >>>>>> @@ -36,7 +36,7 @@ dl-routines = $(addprefix dl-,load lookup object reloc deps \ >>>>>> exception sort-maps lookup-direct \ >>>>>> call-libc-early-init write \ >>>>>> thread_gscope_wait tls_init_tp \ >>>>>> - debug-symbols minimal-malloc) >>>>>> + debug-symbols minimal-malloc audit) >>>>> >>>>> You can drop the #ifdef SHARED if you add this to rtld-routines. >>> >>> Ack, I will change it. >> >> I recalled why I addon dl-routines: _dl_audit_pltexit is currently required >> for static build as well. I can refactor it, but I think it simpler to >> added the SHARED instead. > > I think the usual way is to add stubs to elf/dl-support.c, with a > comment why this is needed (different trampolines glued together in the > build system). This obviously can't be called for static executables. Ack.