From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from iguana.tulip.relay.mailchannels.net (iguana.tulip.relay.mailchannels.net [23.83.218.253]) by sourceware.org (Postfix) with ESMTPS id B8CB53858D3C for ; Thu, 5 May 2022 04:26:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B8CB53858D3C X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C3A385A0C6B; Thu, 5 May 2022 04:26:20 +0000 (UTC) Received: from pdx1-sub0-mail-a305.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1F66B5A10BB; Thu, 5 May 2022 04:26:09 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1651724780; a=rsa-sha256; cv=none; b=MyV31jo443Y4PxPz2RzoeX7/Ylj2g9XK3uDZ1C+GLZH2Z7PaXJPE2EnCEPols+3W4CdUoq Yep2whlaudAeFLAjvh0iepsHLQL47s7JbvpZk3KDRYI+lmRgMiGcMih8I1rPo67VQ9CP6r Zm/eyzDTl4rpDHsT3lDKKdzT1EvlZbV3ObaMy7cZT4Z+rrhEeiwZ0iZmotnth8tHsVaHe7 H7leTC8Mpw7s+CKPNQkIznPA/GC5Jaw/e2vTxa2VeufYSfaGx/oKmqJH66frTXBiFrwPAU 3ffXb6HTyZQXdbOVGGyUqtQ8RE6NEMW88oFf7R2QyWC/d5E5eZURVf0fyNRtHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1651724780; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUOEHs7bIaQfYs761dwDV60kLPPyYf5hUpPhSCZq7cw=; b=sYkDsbYeilp7VgLUblDdTGTtdpRh8UqnBfc0QlgUoMKIhvpkTHyJ98EQgIr2upxQBnjWQY 9bGwWbYjWleeE/v4qfqDpp10VczG+2ujmcvLkxhjVjFttppTzSzv22eR86hy5AaZPLskW8 Fo7bV8JzLfbgxMpUUdUzzmuM+ukYrdOAThOwN4HUa9S0LI3++up+zIrRUX1vnd9tmoVjjh 3wpqfaUMjIQG7cZFzKdHQ/XF6gAQTJUdTznoZwb/jCvucLkKDh8jLU10YM1X+fUfWWuzSo SemSGCDsOy7QuJ5NboCX48TBHEjYYIBQgulT7uAR78op3455uOUlfTy+Z936dQ== ARC-Authentication-Results: i=1; rspamd-847dd8955c-8zvzc; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Drop-Shrill: 5c8ac0296f43968a_1651724780655_2156931703 X-MC-Loop-Signature: 1651724780655:2631902537 X-MC-Ingress-Time: 1651724780655 Received: from pdx1-sub0-mail-a305.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.106.158.137 (trex/6.7.1); Thu, 05 May 2022 04:26:20 +0000 Received: from [192.168.1.174] (unknown [1.186.223.145]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a305.dreamhost.com (Postfix) with ESMTPSA id 4Kv0xn0pcrz1PV; Wed, 4 May 2022 21:26:04 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 09:56:00 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v2 4/4] clock_settime/clock_gettime: Use __nonnull to avoid null pointer Content-Language: en-US To: Xiaoming Ni , drepper@redhat.com, lukma@denx.de, adrian.ratiu@collabora.com, schwab@linux-m68k.org, fweimer@redhat.com, adhemerval.zanella@linaro.org Cc: libc-alpha@sourceware.org, wangle6@huawei.com References: <20220428122529.108208-1-nixiaoming@huawei.com> <20220505030111.111197-1-nixiaoming@huawei.com> <20220505030111.111197-5-nixiaoming@huawei.com> From: Siddhesh Poyarekar In-Reply-To: <20220505030111.111197-5-nixiaoming@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3488.4 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 04:26:26 -0000 On 05/05/2022 08:31, Xiaoming Ni via Libc-alpha wrote: > clock_settime() > clock_settime64() > clock_gettime() > clock_gettime64() > Add __nonnull((2)) to avoid null pointer access. > > Link: https://sourceware.org/bugzilla/show_bug.cgi?id=27662 > Link: https://sourceware.org/bugzilla/show_bug.cgi?id=29084 > Signed-off-by: Xiaoming Ni > --- LGTM. Reviewed-by: Siddhesh Poyarekar Do you have commit access or do you need someone to push this for you? Thanks, Siddhesh