From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91111-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 119203 invoked by alias); 17 Mar 2018 00:26:16 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 119192 invoked by uid 89); 17 Mar 2018 00:26:15 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:sk:zimbra., H*RU:sk:zimbra., HX-HELO:sk:zimbra., Hx-spam-relays-external:sk:zimbra.
X-HELO: zimbra.cs.ucla.edu
Subject: Re: Fix signed integer overflow in random_r (bug 17343)
To: Joseph Myers <joseph@codesourcery.com>, libc-alpha@sourceware.org
References: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk>
From: Paul Eggert <eggert@cs.ucla.edu>
Message-ID: <be4d13fb-ba70-681d-63ce-ba2bed6ead68@cs.ucla.edu>
Date: Sat, 17 Mar 2018 00:26:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1803161732060.20069@digraph.polyomino.org.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-03/txt/msg00418.txt.bz2

Joseph Myers wrote:
>         int32_t val = state[0];
> -      val = ((state[0] * 1103515245) + 12345) & 0x7fffffff;
> +      val = ((state[0] * 1103515245U) + 12345U) & 0x7fffffff;

The first assignment to VAL (in the unchanged line) is unnecessary; I suggest 
coalescing the two lines.