From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 5CA5E385AC29 for ; Fri, 28 Apr 2023 17:45:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CA5E385AC29 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.99,235,1677571200"; d="scan'208";a="4265689" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 28 Apr 2023 09:45:09 -0800 IronPort-SDR: tjFqsyAh8m7lck+SIyWqK8iwcqfdux0zDTOV0mW8RT/siim1ENfocCf/XL9RQus8/Fb4Ki9eg/ KZN8haGgj2xetK7VpgO+YatmN5Tnk7lBFUbQhqn4gUOr23H+AafXpVpwNTeVCh2iM3Fi7dmzdp Ur7GJ0ZUU5HAb674NS+Wcos4T9cnepXBdiOo8FH/+AQMGqhm7F2wkhfyuvLK1lL1nnmxvzpR8V 43Ua9U8tOtc2oj26E26uhhDtVz19C1xVKso7i0DRrqposDknwnZkKORII8Z/PKnoDRaHCeTktb 700= Date: Fri, 28 Apr 2023 17:45:04 +0000 From: Joseph Myers To: Palmer Dabbelt CC: , Hsiangkai Wang , Vincent Chen Subject: Re: [COMMITTED 1/2] riscv: Resolve symbols directly for symbols with STO_RISCV_VARIANT_CC. In-Reply-To: <20230428140427.13133-1-palmer@rivosinc.com> Message-ID: References: <20230428140427.13133-1-palmer@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3107.0 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: How was this tested? I've seeing test failures (for all build-many-glibcs.py configurations) that look like they were caused by this patch. FAIL: elf/tst-glibcelf FAIL: elf/tst-relro-ldso FAIL: elf/tst-relro-libc /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4013: error: macro STO_RISCV_VARIANT_CC redefined /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3941: note: location of previous definition /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:4023: error: macro DT_RISCV_VARIANT_CC redefined /scratch/jmyers/glibc-bot/src/glibc/scripts/../elf/elf.h:3937: note: location of previous definition Traceback (most recent call last): File "/scratch/jmyers/glibc-bot/src/glibc/elf/tst-glibcelf.py", line 23, in import glibcelf File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 226, in _elf_h = _parse_elf_h() File "/scratch/jmyers/glibc-bot/src/glibc/scripts/glibcelf.py", line 223, in _parse_elf_h raise IOError('parse error in elf.h') OSError: parse error in elf.h https://sourceware.org/pipermail/libc-testresults/2023q2/011183.html -- Joseph S. Myers joseph@codesourcery.com