From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id EED9F3858281 for ; Thu, 8 Dec 2022 18:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EED9F3858281 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x331.google.com with SMTP id db10-20020a0568306b0a00b0066d43e80118so1371678otb.1 for ; Thu, 08 Dec 2022 10:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=mKLZb2U2EZ99FhbEscr4BQLuLXQQ0vAzC83tCjyCvcU=; b=y1Wn7g0f6GSmYL+0AjpRdbl+yCnflMz+VJvBdSCg4az2EGf6z+nb12pBArQzzm0Ggn gxKLglGXdkvt3E+uzz5qoHRrCvd5t/Bp2XXsDO8h+Lr/9gV2RnukopkcHVfqV/PcEvzt P7XJk582jZT0H9Ad2M41SPlNGTpZ2xNj0W37IzrmVdFQP1y0UMa0GZwRq55TB4fdq95u h4NIgv4SYREmtehvnSOxTv/PHYZWeCrkCSTw+LBZ8URBLmWBgZCeIwJvghSx0+wyswBv mqawdp9GuPMSrDrb9jeoyq2GkQwlN5YbD79pU0iFxCrXG96lXN1oyzVUzvgsHRDC/3Lv BBag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mKLZb2U2EZ99FhbEscr4BQLuLXQQ0vAzC83tCjyCvcU=; b=6CMusF4qRLPbHP7hlHq+8WgCDDbPOjzLm0x9hbP45hyly2yySFiSDn6o2IlMfn+8bT IgRbyn7dDbfAO1SZ2TJh1bghxLUcu0iSR+WZX/x5Yj1dJhsQnKC/ai2+/CoYToHrTCkI Q6/JqMNCORwIIuCS9qtGLrM8GLE8ziN4GC6F/9TsfAKirleis81/H7ISl2F+W8uT5EfZ zra4C0lejqD/1nAJpbMwvraS8pi/xCMnbU84vbSIa8WqT9GygarKEiRkrkojjHoXtCra RSNnEHtreWqEza43dvUiFhwL3P6IovrMBqS2wANL29vec6kHOWOhpFAzfXS9uXbMiC/y QJEg== X-Gm-Message-State: ANoB5pn2T7CnZmbz5JK5Qa7slInDCGFoX4krHZEDEv0GNUgEdq9c3Xll 8dDIb5r1r5+505D+ggNMYGwJ8g== X-Google-Smtp-Source: AA0mqf4+NpFgcmPIfj3OQ7QSvaPs7p+NUKWwodKiz9FpUDZXth2U2rDGNL02JONCy0234sIOzbBWUg== X-Received: by 2002:a05:6830:1c7:b0:663:d3ce:ca26 with SMTP id r7-20020a05683001c700b00663d3ceca26mr38063120ota.67.1670523816187; Thu, 08 Dec 2022 10:23:36 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:6793:d83e:e871:6162:c8c0? ([2804:1b3:a7c2:6793:d83e:e871:6162:c8c0]) by smtp.gmail.com with ESMTPSA id q204-20020acaf2d5000000b00354d8589a15sm10818654oih.45.2022.12.08.10.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 10:23:35 -0800 (PST) Message-ID: Date: Thu, 8 Dec 2022 15:23:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH] : Make bsd_signal available with _GNU_SOURCE Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org References: <8735a3tlg9.fsf@oldenburg.str.redhat.com> <87r0x9hils.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87r0x9hils.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/12/22 15:10, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 28/11/22 07:36, Florian Weimer via Libc-alpha wrote: >>> The declaration does not conflict with anything. This simplifies >>> porting older software to C99 compilers which do not support implicit >>> function declarations and which need -D_GNU_SOURCE for other function >>> declarations. Using __USE_MISC does not seem appropriate here because >>> other systems (e.g., FreeBSD) do not declare bsd_signal. >> >> I am not sure about this, bsd_signal is a POSIX deprecated and I think >> old software should really move to sigaction or define the correct flags >> to explicit use it. > > And I thought this was the least controversial patch. 8-/ > > If -D_GNU_SOURCE is not the superset of all functionalities, it gets > more difficult to obtain all function prototypes, as needed for building > with stricter C99 compilers. Currently, with default GCC flags, this > builds anyway due to an implicit function declaration, and I'd like to > preserve this behavior with GCC 14. > > What about adding a deprecation warning? I think deprecation works better here, I kind reluctant because moving it to _GNU_SOURCE means that we are 'promoting' a symbol where there is already a replacement.