From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from brown.birch.relay.mailchannels.net (brown.birch.relay.mailchannels.net [23.83.209.23]) by sourceware.org (Postfix) with ESMTPS id F20763858D39 for ; Mon, 15 Nov 2021 02:40:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F20763858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 81F0F6210F7; Mon, 15 Nov 2021 02:40:49 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 1C2CC62115F; Mon, 15 Nov 2021 02:40:49 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.114.196.213 (trex/6.4.3); Mon, 15 Nov 2021 02:40:49 +0000 X-MC-Relay: Junk X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Drop-Grain: 48f5848566a76590_1636944049347_680199376 X-MC-Loop-Signature: 1636944049347:1216451845 X-MC-Ingress-Time: 1636944049347 Received: from [192.168.1.174] (unknown [1.186.223.29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4HstjC4gr5z2M; Sun, 14 Nov 2021 18:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1636944048; bh=0GXuXOLvsI5vZzCc2yygmeKbof4=; h=Date:Subject:From:To:Content-Type:Content-Transfer-Encoding; b=FUT3fGmAGW6LHSVhGxNFtAM55yuJvkr3FMT08Wty3kJxQwzyPW7HCzeRjy0Tfp4xh hFjuHhTf6aswPnavGZs9IXj1Npuai+fYfw89iFhILSOrQy6COXKvlctF6rI9w4Sklk MGwCow0M9fHBAZiegXuvRNPo7MmJ8MfUHZD3pZMs= Message-ID: Date: Mon, 15 Nov 2021 08:10:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH] malloc: Fix malloc debug for 2.35 onwards Content-Language: en-US From: Siddhesh Poyarekar To: Stafford Horne , GLIBC patches References: <20211113004047.1980486-1-shorne@gmail.com> <98e3b40a-3d1f-bac9-997b-22a659a1200b@gotplt.org> In-Reply-To: <98e3b40a-3d1f-bac9-997b-22a659a1200b@gotplt.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3032.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Nov 2021 02:40:52 -0000 [sorry, hit send too soon] On 11/15/21 08:04, Siddhesh Poyarekar wrote: > What symbols does this change generate?  Could you please share the > output of objdump -T malloc/libc_malloc_debug.so from your build? > Basically the idea of SHLIB_COMPAT usage here is twofold: first, to ensure that the symbol versions in libc_malloc_debug.so are at the exact same version as those in libc.so and second, to prevent linking against libc_malloc_debug.so. In that sense, I think SHLIB_COMPAT usage is a hack. The correct way would be to make a new macro like SHLIB_COMPAT, which creates non-default symbol version at the latest version of the libc symbol; i.e. for your port it would be malloc@GLIBC_2.35 and for x86_64 it would be malloc@GLIBC_2.2.5. Siddhesh