From: Florian Weimer <fweimer@redhat.com>
To: libc-alpha@sourceware.org
Subject: Re: [hurd,commited] hurd: Fix build ot misc/tst-preadvwritev2-common.c
Date: Mon, 04 Sep 2017 13:40:00 -0000 [thread overview]
Message-ID: <bf404995-9f3b-1966-8e43-404c6dd983f4@redhat.com> (raw)
In-Reply-To: <35cb0c7b-89c9-094b-5407-a9009a50a5f3@linaro.org>
On 09/04/2017 02:36 PM, Adhemerval Zanella wrote:
>
>
> On 04/09/2017 05:11, Florian Weimer wrote:
>> On 09/03/2017 05:52 PM, Samuel Thibault wrote:
>>> + * misc/tst-preadvwritev2-common.c (RWF_HIPRI, RWF_DSYNC, RWF_SYNC,
>>> + RWF_NOWAIT): Define to 0 if undefined already.
>>> + (do_test_with_invalid_flags): Set invalid_flag to 2 if RWF_SUPPORTED
>>> + boils down to 0.
>>
>> I don't think this is correct. preadv2 etc. are supposed to be part of
>> the GNU API, so if Hurd doesn't have definitions of the WRF_* constants,
>> that's a real bug.
>
> I agree and the default implementation on sysdeps/posix/preadv2.c (which
> I think it is also the default of hurd) will fail for any flag different
> than 0. Should we add a note on manual the current flags are Linux only?
I would have expected that we'd add the flags to the generic API.
Florian
next prev parent reply other threads:[~2017-09-04 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-03 15:52 Samuel Thibault
2017-09-04 8:11 ` Florian Weimer
2017-09-04 12:36 ` Adhemerval Zanella
2017-09-04 13:40 ` Florian Weimer [this message]
2017-09-04 14:05 ` Adhemerval Zanella
2017-09-04 14:06 ` Florian Weimer
2017-09-04 14:07 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf404995-9f3b-1966-8e43-404c6dd983f4@redhat.com \
--to=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).