From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by sourceware.org (Postfix) with ESMTPS id 7EA953858D35 for ; Tue, 23 May 2023 18:09:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7EA953858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-6af713338ccso1241336a34.0 for ; Tue, 23 May 2023 11:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684865345; x=1687457345; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HqvPmoizSsLq6i8yIiZO8EhbooJisoxAvwv0ViUmsns=; b=f4TDkeD62xxQXgLTayEqWQiez5KoL0H6F6vYzFCTRu5MsbBmOhX9X1R5BPvcTe81lV IbECBRwUuDAIbvkZ/V9kT6YxoCYwGZMR0apayBHHveEGvXbS7cNfrWzv9f0YXZsONajY 1FnPgDWlUV65jNoJF35r/2BFbHSgThMOWZh5hoBz3EC+LnKmcmOgCTfVaWOotJQisoF3 OTkVm2l5GE1+hDYIjRGBZlq7dfaAhvTy4mUiisaE2kIdCR9rwQ83Hd8BfMUgRSLR5mEF JdnF0Z2Q2fgqDBC1Gv64No1HU8X4raFAih03tdbQm3HwuHmcym14BD6GYhhTlOPVsHxR GaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684865345; x=1687457345; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HqvPmoizSsLq6i8yIiZO8EhbooJisoxAvwv0ViUmsns=; b=Xm1SJYg+3Hd3nwyJxntgcu+A9lrjFWQXEMe/O/SJ+bpuOs2ubt0Q7zHg9asboX1WqT 2MBeY2+fL5UiUNhasO5UQ7aIdiD2aiem2KsM0JCGdPRS9ZZD/MsBsWRyvGqvZKiub+P0 yxpZigaCIEQ3mxDdOSqs3CRNjZ99LAaoYeXZI2vtUQ/KoXrhpww5MkULJnRPUxO6J532 ihD07LlTWzH8+E3E8f21XmSnn56OL5Ek+xlw0ucBXBYCjHQGJZnkyxTgXjoLZdeZaIjJ iYMY75Ps9Kvgh97aXW3Fsi9omq6z+gPYJ5MoFsqs3EUI1R4irDAp9bVhsT2D/YjZkrmM 3Lww== X-Gm-Message-State: AC+VfDxM+6YioLfYZuIC5GTlR1gwQbv5JV/a0MmQMLjVqnyH+0YDhJfv xFPhNXifo4089ehdN7TVJQ1ACA== X-Google-Smtp-Source: ACHHUZ4eI2Okc4+OlMTQRsBGiEo7ghDVUAvrXlyP0Dyx2MaMLGj3IotnBBFrphaugdALW31v8C4Cow== X-Received: by 2002:a54:4019:0:b0:386:b953:d8f8 with SMTP id x25-20020a544019000000b00386b953d8f8mr7566894oie.37.1684865344648; Tue, 23 May 2023 11:09:04 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:2e05:a4ad:a873:8177:a796? ([2804:1b3:a7c1:2e05:a4ad:a873:8177:a796]) by smtp.gmail.com with ESMTPSA id k8-20020acaba08000000b00397bc1af159sm4222161oif.18.2023.05.23.11.09.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 11:09:04 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 15:09:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] fnmatch: allow character class names with 'z' Content-Language: en-US To: =?UTF-8?Q?Carlo_Marcelo_Arenas_Bel=c3=b3n?= , libc-alpha@sourceware.org References: <20230523073732.6956-1-carenas@gmail.com> <20230523073732.6956-2-carenas@gmail.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230523073732.6956-2-carenas@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 23/05/23 04:37, Carlo Marcelo Arenas Belón via Libc-alpha wrote: > Since d8aaef00a7 (Update., 1999-04-26), there is code to consider > character class names that include that character as invalid > > * posix/fnmatch_loop.c: correct inequality Thanks for patch. There is no need for Copyright entry anymore, so you can skip it on commit message. Also, current practice is to both add a bug report if this is a user-visible issue (which seems so) along with a testcase to avoid any potential regression. Cold you provide both? > > Copyright-paperwork-exempt: yes > --- > posix/fnmatch_loop.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/posix/fnmatch_loop.c b/posix/fnmatch_loop.c > index 8aeec9816f..4be2e20141 100644 > --- a/posix/fnmatch_loop.c > +++ b/posix/fnmatch_loop.c > @@ -283,7 +283,7 @@ FCT (const CHAR *pattern, const CHAR *string, const CHAR *string_end, > p += 2; > break; > } > - if (c < L_('a') || c >= L_('z')) > + if (c < L_('a') || c > L_('z')) > { > /* This cannot possibly be a character class name. > Match it as a normal range. */