From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id B67663850413 for ; Wed, 11 May 2022 13:20:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B67663850413 Received: by mail-oi1-x236.google.com with SMTP id v66so2676926oib.3 for ; Wed, 11 May 2022 06:20:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=TzTHKzkQN3EKeNwI9deGoTuexK0ltYaJXSgAL17Mk6A=; b=ULhx7IwX/UEEyTgNbfY+0Egks2HrBtKJr8NqU4sL5tGsZpa9goCq/HVEdoUTKUGIL6 4h6xcXwQOmL2eyAcmrikID6eIQyNB7O1GFBisBI4T2chBAfI/OkbAqxsvHmNsXvrq4EW npNdufD8m5UuEPkzvGCOMBTsCJz94+2E2ByvR+C/A8o229ysidwmICmUy/hN8Z3loNor ckx05xs1e6btg6n8dDVryFY7913snT4LiW461IwV6f46kJIOoFp/ou8a934TjVy2nAIW TPQbOFRLW7VUZlrrzpxv9amMSrKTuLM/ymssK4a2ENlbjYN3JCZquZPr5fcrN4Cd0cPs 34Ow== X-Gm-Message-State: AOAM532SkfINDtxg0iuDA9TRoovOfQnPd0+HZfoY51JG1G5mVbEAeDQT Td1lU8StAWppHK9r6jb1cOm4FWyFe4eRFg== X-Google-Smtp-Source: ABdhPJx2YG9pQi1/v4E17yUR3b2AensVpmHr6rhfh+yqhiGJc5x45+RKFJVASP+ctKnr577w7zvINQ== X-Received: by 2002:a05:6808:2004:b0:326:7f22:624e with SMTP id q4-20020a056808200400b003267f22624emr2401913oiw.180.1652275248777; Wed, 11 May 2022 06:20:48 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b? ([2804:431:c7ca:5fbd:9d46:f0f6:e4b6:b83b]) by smtp.gmail.com with ESMTPSA id d8-20020a056830004800b006060322126dsm757224otp.61.2022.05.11.06.20.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 06:20:48 -0700 (PDT) Message-ID: Date: Wed, 11 May 2022 10:20:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v4 08/13] LoongArch: Linux Syscall Interface Content-Language: en-US To: libc-alpha@sourceware.org References: <20220509022611.1248063-1-caiyinyu@loongson.cn> <20220509022611.1248063-9-caiyinyu@loongson.cn> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2022 13:20:51 -0000 On 11/05/2022 04:02, Arnd Bergmann wrote: > On Mon, May 9, 2022 at 4:26 AM caiyinyu wrote: > >> +#define __NR_clone 220 >> +#define __NR_clone3 435 > >> +#define __NR_fstat 80 >> +#define __NR_newfstatat 79 > > stat() and newfstatat() are not in the current ABI for the kernel, this needs > to be updated, and the libc wrapper updated to call statx() instead. Assuming a minimal kernel version for loongarch higher than 4.11 (where glibc assumes statx support), these stat definitions does not matter. The sysdeps/unix/sysv/linux/fstatat64.c (which will be the only use since the port will be LFS as default) will always call fstatat64_time64_statx without any fallback. It is still wrong to place them in the loongarch arch-syscall.h, it means that either update-syscall-lists.py has an issue or some bogus kernel headers were used to generate it. > > clone() is still an open question, this may have to be implemented on top > of clone3() > > Arnd