From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115912 invoked by alias); 9 Dec 2019 12:58:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 115903 invoked by uid 89); 9 Dec 2019 12:58:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 00/13] Use GCC builtins for some math functions if desired. To: libc-alpha@sourceware.org References: <1575297977-2589-1-git-send-email-stli@linux.ibm.com> Cc: Adhemerval Zanella , "Joseph S. Myers" From: Stefan Liebler Date: Mon, 09 Dec 2019 12:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <1575297977-2589-1-git-send-email-stli@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit x-cbid: 19120912-0008-0000-0000-0000033F1BDA X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120912-0009-0000-0000-00004A5E4873 Message-Id: X-SW-Source: 2019-12/txt/msg00279.txt.bz2 On 12/2/19 3:46 PM, Stefan Liebler wrote: > Hi, > > this patch-series moves the nearbyint, rint, floor, ceil, trunc and round implementation from sysdeps/ieee754/dbl-64/wordsize-64 to sysdeps/ieee754/dbl-64/ as proposed by Adhemerval: > ttps://www.sourceware.org/ml/libc-alpha/2019-11/msg00085.html > > It also introduces the math-use-builtins.h header with __USE__BUILTIN macros which allows to just use GCC __builtin_ instead of the current common-code implementation. There is a float, double, long double and _Float128 version of this macro for each . > > The generic math-use-builtins.h header is defining all those macros to 0 in order to use the current common-code implenetation. If an architecture wants to use the builtins, an architecture specific math-use-builtins.h needs to be created (e.g. done for s390) where those macros are defined to 1. > > Bye, > Stefan > Hi, thanks for the review so far. I've sent a new version v2 with changes due to Adhemervals comments. See "[PATCH v2 00/18] Use GCC builtins for some math functions if desired." https://www.sourceware.org/ml/libc-alpha/2019-12/msg00258.html Can you have a final look, please? Bye, Stefan