From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id CE9383858D39 for ; Fri, 26 Aug 2022 02:44:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CE9383858D39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from [10.20.4.187] (unknown [10.20.4.187]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Cx72uiMwhjvxwKAA--.42035S3; Fri, 26 Aug 2022 10:44:50 +0800 (CST) Subject: Re: [PATCH 1/2] LoongArch: Fix ptr mangling/demangling features. To: Adhemerval Zanella Netto , Xi Ruoyao , libc-alpha@sourceware.org, joseph_myers@mentor.com, carlos@redhat.com, i.swmail@xen0n.name Cc: xuchenghua@loongson.cn References: <20220823122833.1561228-1-caiyinyu@loongson.cn> <20220823122833.1561228-2-caiyinyu@loongson.cn> <8562da19-d9d3-a4f3-2aae-2a4489af6806@linaro.org> <627c332247e2a3ce48658e2d531f6d7a7df19312.camel@xry111.site> From: caiyinyu Message-ID: Date: Fri, 26 Aug 2022 10:44:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8Cx72uiMwhjvxwKAA--.42035S3 X-Coremail-Antispam: 1UD129KBjvdXoW7Xr47Aw4DJr45JryrZr4Utwb_yoWkCrg_ua 1q934kuw13Aan7tF17Z3Wqq34xKrWUC345XrWDJFnav34kX39xu3ZxZas3uw4Iq3ykJFnx Jr90vrWIy34q9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbxkYjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW7JVWDJwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4 vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xv F2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r 4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487 MxkIecxEwVCm-wCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c 02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_ Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7 CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v2 6r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU5 6c_DUUUUU== X-CM-SenderInfo: 5fdl5xhq1xqz5rrqw2lrqou0/ X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: How about using this patch[1] now to fix this build error first? [1] https://sourceware.org/pipermail/libc-alpha/2022-August/141489.html There is no modify in common files and all happy besides performance overhead of one more instruction. 在 2022/8/26 上午1:01, Adhemerval Zanella Netto 写道: > > On 25/08/22 12:27, Xi Ruoyao wrote: >> On Thu, 2022-08-25 at 12:08 -0300, Adhemerval Zanella Netto wrote: >>> Does is really pay off the complexity to use HAVE_LOONGARCH_EXPLICIT_RELOCS? The >>> PTR_MANGLE is used some specific cases and hardly a hotstop. >> LDST_PCREL added as a macro in sysdep.h, so further assembly >> implementations might reuse it then it may appear in some hot spot. >> >> If we quote "optimization too early is the ultimate evil", we can drop >> it for now and review once we use LDST_PCREL somewhere else. But to me >> this is rather a simple autoconf check and I can't figure out a >> situation where it's evil... > It is more that configure checks might create maintainability burden or just > dead code in the long term, specially where it does have a fallback that works > with no much performance penalty.