From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106218 invoked by alias); 7 Nov 2016 13:10:52 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 106197 invoked by uid 89); 7 Nov 2016 13:10:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Wednesday, wednesday, adjusting, sk:kernel- X-HELO: mail-ua0-f170.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=9hKvybaIFJ5wcJrr1DOlHy21E1FAE+IN2tipZew2e40=; b=mR+kNGetP6JffV8sw6Go4cLP4lWEtD0L5JtE8lGAvNV+ZtT84zPh8JNvGchNhAPPgY EOmyg+BB3JyYJ1FG5pPOBU/JT825n/oRnd+TkVIcd0lHE2x/3Wov58sDzz+AtP2B352Y /gyqpSPI4BPwv47TUAYmBkOrr4DzIP1BKblQC+PXSFvjaNrUMXv73Wxb5j/xtpkzcFBj x8b0PdPQGSwkxtubMGJvrjkUXweUWcGzgsxlLNetNkMgjsJ5J6MB24Ew3gTWoBmliZff WmDXRFWHSgnyOf7zSuQD12wwW7XAf7GDQ0shtuw7WAjiwPrGxcKHYJSMH4miUplRwPEz mfGQ== X-Gm-Message-State: ABUngvcPFwsI1JzhR24eLgxGDxt0/HVtxpxX5GB3jkWvxUbStGeSkxiqqGjks1vERS5Su+XR X-Received: by 10.159.51.129 with SMTP id p1mr3620730uab.67.1478524239038; Mon, 07 Nov 2016 05:10:39 -0800 (PST) Subject: Re: [PATCH v2 12/16] Use shmat syscall for Linux implementation To: Arnd Bergmann , libc-alpha@sourceware.org References: <1478114813-3526-1-git-send-email-adhemerval.zanella@linaro.org> <1478114813-3526-13-git-send-email-adhemerval.zanella@linaro.org> <1569285.WyivNgpc5v@wuerfel> From: Adhemerval Zanella Message-ID: Date: Mon, 07 Nov 2016 13:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1569285.WyivNgpc5v@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00230.txt.bz2 On 07/11/2016 09:02, Arnd Bergmann wrote: > On Wednesday, November 2, 2016 5:26:49 PM CET Adhemerval Zanella wrote: >> @@ -31,17 +28,19 @@ >> void * >> shmat (int shmid, const void *shmaddr, int shmflg) >> { >> +#ifdef __ASSUME_SYSVIPC_SYSCALL >> + return INLINE_SYSCALL_CALL (shmat, shmid, shmaddr, shmflg); >> +#else >> INTERNAL_SYSCALL_DECL(err); >> unsigned long resultvar; >> void *raddr; >> > > I looked at the cross-reference for system call tables and found > that alpha does not define __NR_shmat but instead has __NR_osf_shmat > > Will that get handled correctly by your code? > > Arnd No, but at least it does not prevent alpha build since it uses the syscalls.list instead. However adjusting it should be simple, it would be something like __NR_fadvise64_64 for arm (where it should be __NR_arm_fadvise64_64 and it is handled on kernel-features.h). I tried to avoid remove the syscalls.list usage for architecture that is already using it, but thinking twice for consolidation idea it would be better to have all architecture to use only a simple syscall generation mechanism for a syscall. I will add it on the patch and send a v3.