From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id 1B5CD3857C48 for ; Mon, 27 Jul 2020 00:40:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1B5CD3857C48 Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-FTFsk3j5Pq24jVXV508rjQ-1; Sun, 26 Jul 2020 20:40:56 -0400 X-MC-Unique: FTFsk3j5Pq24jVXV508rjQ-1 Received: by mail-qv1-f70.google.com with SMTP id e6so10208258qva.2 for ; Sun, 26 Jul 2020 17:40:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=FP+5s84w6Nf5rpB3IphBeg5/d5po2cN/Ay84r307+6Q=; b=YD9r+NbeuQjmgmlhDhh3OmZGXb+ry23pdgS6mlNaU41vfVNQknOpYLUkJGuFtEa9Qf GfKF6i/ne2xMVumKB0Q6HJ/wksN1mk8bw3kViIaAdnNcgS9HsPP9erA0z1HnqNncCqVh b+IWiIR4CN1Mh6mqOD1R+dXRZRxUPuasdntppyR9z9NBL9Jdh8v6fiWfBZcPkzMAC02J vSbpGhh1r8LsI9a/INaA31j2P/pl4vroy230YoHJSZV0zgI0eatiVAb0EETZP5P7aesR 1oiikg/MADFmD5nShgYfQm5hVA4jcrZe5qjWOtM0gd4EA1fZxLEIPpXKRL1iOzKAFo/H t7OQ== X-Gm-Message-State: AOAM530ViIRUsROmj4mlxsc0X89jBje7Kz7CSfpo22/S2+422hWCLkG6 8tUJBGW5QWMuy7q/akscg6f/R8tOeWwERwNMVkxCRL1TrohLBzTtl+JRXvw7oaA9nGWzPHFwgfW 4X/zcyZJnu/MpfO7hq5/B X-Received: by 2002:a0c:b41d:: with SMTP id u29mr17167149qve.191.1595810455905; Sun, 26 Jul 2020 17:40:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjz138KTMNNrqMTaoQx3YcOAgnkkiP0/syJrd/TtPi/Q08/wK1A9wGNVuzwuT7XCyD4XS5IA== X-Received: by 2002:a0c:b41d:: with SMTP id u29mr17167139qve.191.1595810455698; Sun, 26 Jul 2020 17:40:55 -0700 (PDT) Received: from [192.168.1.4] (198-84-170-103.cpe.teksavvy.com. [198.84.170.103]) by smtp.gmail.com with ESMTPSA id n62sm16401247qkc.0.2020.07.26.17.40.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 26 Jul 2020 17:40:54 -0700 (PDT) Subject: Re: [PATCH v3 1/2] BZ #17645, fix slow DSO sorting behavior in dynamic loader To: cltang@codesourcery.com, Andreas Schwab Cc: GNU C Library , Catherine Moore References: <87a724uhtf.fsf@igel.home> <87tv0ct1vl.fsf@igel.home> <456fbddc-7915-19da-3ffe-e58b86ae7980@redhat.com> <1427b370-7400-afd0-16e8-55c1072db20e@mentor.com> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Sun, 26 Jul 2020 20:40:53 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1427b370-7400-afd0-16e8-55c1072db20e@mentor.com> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 00:40:59 -0000 On 7/22/20 2:10 PM, Chung-Lin Tang wrote: > I only now notice that "permute" vs "permutate" is an issue :) I've corrected the > spelling as you've suggested. > > The v3 patch is attached, please see if this is now okay for committing. I'm going to review this shortly, but it's too late in the release to add it to 2.32. My plan, if you agree, is as follows: (a) Review this promptly this week. (b) Switch the sense of the default to just use the new DFS sort. (c) Open 2.33 for development and commit the changes. (d) Sync Fedora Rawhide and spend the next 5 months testing this in Rawhide. There are still a few more changes we need to make in the test generation, for example the tests don't use support/test-driver.c which means they could hang the entire testsuite and they don't support timeouts because of this. We should follow generating the test such that the executable uses test-drive.c like all new tests should. This way we can catch tests that used to take 200s and now take 1s (default timeout at 20s). -- Cheers, Carlos.