From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.maple.relay.mailchannels.net (bumble.maple.relay.mailchannels.net [23.83.214.25]) by sourceware.org (Postfix) with ESMTPS id 3D31138323FF for ; Thu, 5 Oct 2023 12:55:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D31138323FF Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 26660900760; Thu, 5 Oct 2023 12:55:19 +0000 (UTC) Received: from pdx1-sub0-mail-a312.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id A96D09006C4; Thu, 5 Oct 2023 12:55:18 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696510518; a=rsa-sha256; cv=none; b=ggTtEU8GSGAIl1Hufbhtr33pslq2RTIm1DPwvltqOgYkeRQKqWMZ8foTR8A3VEhqEgT/QU 11iWCXC89TL+PxDH/ZoDShBhU2rV5zEXjKtjJEvonP2uF8wvq3vOWC1NWLytEEbnmPC3WE sheR8z8fS8kB0tglKS4tlyfQ0E1LGzde6WmPu+rI1ZoW/WPvwSkz8oOtOhQzu3w/WMjJYF gLIgcRyq/JmoODF+Mja4RPCjRmLnZYyMSX7X6tLJP9FAr6Y6audktH2w4BpUNlq/KscqYJ ZmQm0ItPVXmFxs9mGOQVWjn8+NDOOXg8vrh2WdLcVeZLaBrKrFNSQN4YMtXtfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696510518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b5ocDLskskuYJ+Y/PfamAbWqqFYRLPJV5Jwjtxq1Z6o=; b=awHIG/TzNzkP97N2H6rCdcMAX0iUbKDXGBvo87da4LiXVyIukHqz7SUqrtkfxKc4IsREae ceEs7nNzFArTCLXk4WiBVgRjN9c6oK/3keS1Qb30OtYNW2YFTpgFrjB6OrDG9DdLihMlBs dszVld97dpXC3DP60Dw5GhDQUsh4q7x9F98u1PfzA3dKOZLnwqopnMgUFCRRo9W+Ym+ofg qybdKNbbQ3zzlwpg1nRNg+s0d9JEMbKWAplsrssiTGmXuA4+fApjJ3fXyhzEMA3rLRx95g efuWlNkoP4bFPANddC07m9Ds8EjymI7bBsG+ZDhR2xStt8Gbbnc15f7GFGpyaA== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-2jfpf; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Left-Suffer: 065105521e927908_1696510518994_74719691 X-MC-Loop-Signature: 1696510518994:3629721291 X-MC-Ingress-Time: 1696510518994 Received: from pdx1-sub0-mail-a312.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.101.166.200 (trex/6.9.1); Thu, 05 Oct 2023 12:55:18 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a312.dreamhost.com (Postfix) with ESMTPSA id 4S1WkG1HXJz1s; Thu, 5 Oct 2023 05:55:18 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2023 08:55:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Content-Language: en-US To: Szabolcs Nagy , Adhemerval Zanella Netto , libc-alpha@sourceware.org Cc: fweimer@redhat.com, carlos@redhat.com References: From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1168.3 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-05 04:19, Szabolcs Nagy wrote: > i'd fix this in one place that makes the behaviour easy > to reason about: _dl_next_ld_env_entry in rtld should > just return empty in secure mode and same for getenv, > internally it should return empty. > > then we know that nothing in libc can depend on the env. > (if something parses env directly that should be fixed) > > if anything, there should be a whitelist, not blacklist > of env vars. That won't work because it would require knowledge of (or a mechanism to specify) safety of environment variables used by the application and its children. The current unsecvars approach is probably the best option. > of course this changes behaviour, so if we want to be > bw compat then we have to live with the current unsetenv > logic. The current unsetenv logic is well reasoned IMO; the tunables layer made it complicated and it ought to be sufficient to just remove that. But that would require dropping the memory tagging tunable from SXID_IGNORE and erasing GLIBC_TUNABLES by putting it in unsecvars.h. Thanks, Sid