From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-91000-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 61786 invoked by alias); 13 Mar 2018 11:45:38 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 61625 invoked by uid 89); 13 Mar 2018 11:45:35 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=personal, HContent-Transfer-Encoding:8bit
X-HELO: mail-qk0-f193.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:cc:references:from:message-id:date
         :user-agent:mime-version:in-reply-to:content-language
         :content-transfer-encoding;
        bh=fK1cN6RU55jmP42drTdqIxc0NV9APmZCeFfH9C3u0gE=;
        b=qHqmB3Vifwr+fIA/RCMvF/6gF/qK/vwp+IxiFb+QPrXjhFLQU+9f2PplZOX/Ur+t6m
         gBvu84kjktOH9wEt7ghinxb/082l3RxeSXwdf6wxpt/lX49UKmrjEt9afzqgjyhDe3wH
         IdvIPZGoiVe7UGsc5C2ULqYpwB/VSI/EffTRCg7Giu818/X6mzvmtCsoms0ley0ySNcg
         ljbiRaifNPzbtgl+DFhONIjKs6oXIK8tIWKzUiY76lyDhddY0a/cXgg9erNGCMs3+ho5
         OK9t5bEY/Tr6YwfKpx49mWy8AIhaF/LavIkYTj48QXAJRJJkkNOQaSAXpwuCSluZ1Qgl
         kOAw==
X-Gm-Message-State: AElRT7GLGX88MxpLGJ+dSsFG1YEdxxRgfot5Rce1UAKHq+qCI7YzeNgc
	tiQYKx0zLFibCfNgM0xD9pyrPHAjt3c=
X-Google-Smtp-Source: AG47ELuL5haffyYJMt6Q+bQ8A/f+z6FL49K0flKK2ls3YNBVtz3Y2o4fOrReHRyqMz2dPA5uDdkqPg==
X-Received: by 10.55.185.1 with SMTP id j1mr472489qkf.134.1520941532405;
        Tue, 13 Mar 2018 04:45:32 -0700 (PDT)
Subject: Re: [PATCH 1/9] Use STRFMON_LDBL_IS_DBL instead of __ldbl_is_dbl.
To: Zack Weinberg <zackw@panix.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
References: <20180307193205.4751-1-zackw@panix.com>
 <20180307193205.4751-2-zackw@panix.com>
 <d5a7a156-22a1-0ec4-4b0f-82d7e30faa8b@linaro.org>
 <CAKCAbMhs-DDRqnqbAFcwKcq61n8T=F341gJyMa_Aj0v5mNE=cw@mail.gmail.com>
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Message-ID: <c128bbde-82c4-7cb0-39f9-6fbf2acfad41@linaro.org>
Date: Tue, 13 Mar 2018 11:45:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <CAKCAbMhs-DDRqnqbAFcwKcq61n8T=F341gJyMa_Aj0v5mNE=cw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2018-03/txt/msg00307.txt.bz2



On 12/03/2018 18:10, Zack Weinberg wrote:
> On Mon, Mar 12, 2018 at 4:36 PM, Adhemerval Zanella
> <adhemerval.zanella@linaro.org> wrote:
>>>    va_start (ap, format);
>>> -  res = __nldbl___vstrfmon (s, maxsize, format, ap);
>>> +  ret = __vstrfmon_l_internal (s, maxsize, _NL_CURRENT_LOCALE, format, ap,
>>> +                               STRFMON_LDBL_IS_DBL);
>>>    va_end (ap);
>>> -  return res;
>>> +  return ret;
>>>  }
>>
>> I tend to frown at variable names changes such this case, it just add diff
>> lines without improvement in code readability.
> 
> This might look pointless by itself, but as you go through the other
> patches you will see that many other functions in this file are using
> _different_ conventions for their variable names, so making the whole
> file be consistent is worthwhile IMHO.  I thought it was better to
> touch each function as I was making other changes to it anyway.
> 
> zw
> 

Fair enough, this is more a personal preference and this is not really 
a patch blocker (sorry if my ack showed this intention).