From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dog.elm.relay.mailchannels.net (dog.elm.relay.mailchannels.net [23.83.212.48]) by sourceware.org (Postfix) with ESMTPS id 8968F3857817 for ; Thu, 19 Aug 2021 12:26:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8968F3857817 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 29DFD18287F; Thu, 19 Aug 2021 12:26:27 +0000 (UTC) Received: from pdx1-sub0-mail-a83.g.dreamhost.com (100-96-16-111.trex-nlb.outbound.svc.cluster.local [100.96.16.111]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id B91741828BA; Thu, 19 Aug 2021 12:26:26 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a83.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.111 (trex/6.3.3); Thu, 19 Aug 2021 12:26:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Stop-Illustrious: 7bcefc100c40e9c0_1629375987020_1265595528 X-MC-Loop-Signature: 1629375987020:1812465052 X-MC-Ingress-Time: 1629375987019 Received: from pdx1-sub0-mail-a83.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTP id 74ECE7F221; Thu, 19 Aug 2021 05:26:26 -0700 (PDT) Received: from [192.168.1.165] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a83.g.dreamhost.com (Postfix) with ESMTPSA id 47BEF7F20F; Thu, 19 Aug 2021 05:26:22 -0700 (PDT) Subject: Re: [PATCH v2 0/4] malloc: Improve Huge Page support To: Adhemerval Zanella , libc-alpha@sourceware.org Cc: Norbert Manthey , Guillaume Morin References: <20210818142000.128752-1-adhemerval.zanella@linaro.org> <5e37cb66-fd93-5d27-ec7b-28f7cf636246@linaro.org> <9c13a602-573a-666f-071c-f88c1f857b5c@sourceware.org> <21440481-f2b2-8112-1d7f-be59eb43c80e@linaro.org> X-DH-BACKEND: pdx1-sub0-mail-a83 From: Siddhesh Poyarekar Message-ID: Date: Thu, 19 Aug 2021 17:56:17 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <21440481-f2b2-8112-1d7f-be59eb43c80e@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3489.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2021 12:26:33 -0000 On 8/19/21 5:34 PM, Adhemerval Zanella wrote: > I think this would be an additional tunable, we still need to handle > the case where mmap() fails either in default path (due maximum number > of mmap() per process by kernel or when the poll is exhausted for > MAP_HUGETLB). > > So for sbrk() call, should we align the increment to huge page and > issue the madvise() if the tunable is set to use huge pages? Yeah it's a reasonable compromise. I've been thinking about getting rid of max_mmaps too; I don't see much use for it anymore. Siddhesh