From: Florian Weimer <fweimer@redhat.com>
To: sellcey@cavium.com, Joseph Myers <joseph@codesourcery.com>
Cc: libc-alpha@sourceware.org, Szabolcs Nagy <szabolcs.nagy@arm.com>,
nd <nd@arm.com>
Subject: Re: Obsolete matherr, _LIB_VERSION, libieee.a
Date: Thu, 24 Aug 2017 18:55:00 -0000 [thread overview]
Message-ID: <c23167e3-4d5e-7b89-133c-6fb1279e97ac@redhat.com> (raw)
In-Reply-To: <1503595246.28672.90.camel@cavium.com>
On 08/24/2017 07:20 PM, Steve Ellcey wrote:
> -#undef _LIB_VERSION
> +
> +#if TEST_COMPAT (libm, GLIBC_2_0, GLIBC_2_27)
> +
> +# undef matherr
> +# undef _LIB_VERSION
> compat_symbol_reference (libm, matherr, matherr, GLIBC_2_0);
> compat_symbol_reference (libm, _LIB_VERSION, _LIB_VERSION, GLIBC_2_0);
>
> @@ -45,5 +48,12 @@ do_test (void)
> acos (2.0);
> return fail;
> }
> +#else
> +static int
> +do_test (void)
> +{
> + return 0;
> +}
> +#endif
Does the fail to compile, or does it fail to link?
Maybe it is possible to make this slightly more regular. Although the
expansion of compat_symbol_reference is difficult to remove because GCC
does not see it, so it is not optimized away.
Thanks,
Florian
next prev parent reply other threads:[~2017-08-24 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-17 21:30 Joseph Myers
2017-08-21 20:16 ` Adhemerval Zanella
2017-08-21 21:45 ` Joseph Myers
2017-08-21 20:32 ` Gabriel F. T. Gomes
2017-08-21 21:17 ` Joseph Myers
2017-08-23 20:21 ` Steve Ellcey
2017-08-24 9:27 ` Szabolcs Nagy
2017-08-24 12:32 ` Joseph Myers
2017-08-24 17:20 ` Steve Ellcey
2017-08-24 17:25 ` Joseph Myers
2017-08-24 17:44 ` Steve Ellcey
2017-08-24 18:08 ` Joseph Myers
2017-08-24 18:55 ` Florian Weimer [this message]
2017-08-24 21:06 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c23167e3-4d5e-7b89-133c-6fb1279e97ac@redhat.com \
--to=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
--cc=sellcey@cavium.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).