From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123756 invoked by alias); 17 Oct 2019 19:49:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 123743 invoked by uid 89); 17 Oct 2019 19:49:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.5 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS,T_FILL_THIS_FORM_SHORT autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fPKJ4RRH3oY5DOJtvzZbCDbHqgqmyxhllVUNtTvVJs8=; b=hGomZEj5c/W3qWS+E9zWxZKtLF/dP1UdTAM/QnWrBQDfZ17bKvmKiKJ0cUNLdIa7do IDjR6oI0F4YRmUaNB5Kp+lD7yx/pDhE9lsYLQe2+2uCROPDvbsmVJvuducRDdopyLwx9 EQeuHNG9UDFLJ71zBxtAPl5KY/RdspNMM0sTp7AG2ArrYnAz8ZdLGTWHqaA2XgDlhdY5 bNhp1ZVkrSAgwfYwGRImURoZqAGM4Zda2DykkDGVfW268IkmoY2ITk4HA1L00zF7zjPj v7lk9NrA8rd6Aq6HYxp+Dp2EjEkQ682OyT373Cony85GnjkysZqEYsElxRntkrabBqvA WdCg== Return-Path: Subject: Re: [PATCH 2/3] sysvipc: Implement semop based on semtimedop To: Florian Weimer , Joseph Myers Cc: libc-alpha@sourceware.org, "Paul A . Clarke" References: <20191011191554.10870-1-adhemerval.zanella@linaro.org> <20191011191554.10870-2-adhemerval.zanella@linaro.org> <878spl6mfe.fsf@oldenburg2.str.redhat.com> <87k193w4c4.fsf@oldenburg2.str.redhat.com> From: Adhemerval Zanella Openpgp: preference=signencrypt Message-ID: Date: Thu, 17 Oct 2019 19:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <87k193w4c4.fsf@oldenburg2.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-10/txt/msg00540.txt.bz2 On 17/10/2019 16:37, Florian Weimer wrote: > * Joseph Myers: > >> I'm seeing a build failure for i686-gnu I suspect is caused by this >> change. >> >> In file included from : >> ./../include/libc-symbols.h:545:33: error: '__EI___semtimedop' aliased to undefined symbol '__GI___semtimedop' >> extern thread __typeof (name) __EI_##name \ >> ^~~~~ >> ./../include/libc-symbols.h:541:3: note: in expansion of macro '__hidden_ver2' >> __hidden_ver2 (, local, internal, name) >> ^~~~~~~~~~~~~ >> ./../include/libc-symbols.h:550:29: note: in expansion of macro '__hidden_ver1' >> # define hidden_def(name) __hidden_ver1(__GI_##name, name, name); >> ^~~~~~~~~~~~~ >> ./../include/libc-symbols.h:619:32: note: in expansion of macro 'hidden_def' >> # define libc_hidden_def(name) hidden_def (name) >> ^~~~~~~~~~ >> semtimedop.c:32:1: note: in expansion of macro 'libc_hidden_def' >> libc_hidden_def (__semtimedop) >> ^~~~~~~~~~~~~~~ >> >> https://sourceware.org/ml/libc-testresults/2019-q4/msg00085.html > > This should fix it. > > Thanks, > Florian > > 8<------------------------------------------------------------------8< > Subject: Remove libc_hidden_def from __semtimedop stub > > This breaks the Hurd build after commit 765cdd0bffd77960ae852104f > ("sysvipc: Implement semop based on semtimedop") added it to the stub. > > ----- > sysvipc/semtimedop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sysvipc/semtimedop.c b/sysvipc/semtimedop.c > index 68707d6ade..a4b750c813 100644 > --- a/sysvipc/semtimedop.c > +++ b/sysvipc/semtimedop.c > @@ -29,6 +29,5 @@ __semtimedop (int semid, struct sembuf *sops, size_t nsops, > return -1; > } > weak_alias (__semtimedop, semtimedop) > -libc_hidden_def (__semtimedop) > > stub_warning (semtimedop) > Ugh, I though I removed it from last iteration, thanks for catching it.