From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-74084-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 94433 invoked by alias); 26 Oct 2016 05:42:38 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 94405 invoked by uid 89); 26 Oct 2016 05:42:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL autolearn=no version=3.3.2 spammy=wednesday, blank
X-HELO: homiemail-a82.g.dreamhost.com
Reply-To: siddhesh@sourceware.org
Subject: Re: [PATCH 2/2] Document the M_ARENA_* mallopt parameters
References: <1477318076-22231-1-git-send-email-siddhesh@sourceware.org>
 <1477318076-22231-3-git-send-email-siddhesh@sourceware.org>
 <xnh980qekp.fsf@greed.delorie.com>
To: DJ Delorie <dj@redhat.com>
Cc: libc-alpha@sourceware.org
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
Message-ID: <c28ab047-ad6a-920c-c08d-a36227725b7e@sourceware.org>
Date: Wed, 26 Oct 2016 05:42:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <xnh980qekp.fsf@greed.delorie.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-10/txt/msg00444.txt.bz2

On Wednesday 26 October 2016 03:25 AM, DJ Delorie wrote:
> Siddhesh Poyarekar <siddhesh@sourceware.org> writes:
>> -/*  Non public mallopt parameters.  */
>>  #define M_ARENA_TEST -7
>>  #define M_ARENA_MAX  -8
> 
> Hmmm... if these are now public, do they need to be moved elsewhere?
> Like, malloc.h ?

They're already there in malloc.h.  I'll push a follow-up patch if they
can be removed.

>> +The presence of multiple @code{arenas} allows multiple threads to allocate
>> +memory simultaneously in their own separate arenas, thus improving performance.
> 
> Not quite true - there isn't one arena per thread, there are N arenas
> per M threads.  Probably better to say "... simultaneously in separate
> arenas ..."

OK.

>> +environment variable @code{MALLOC_ARENA_TEST} to the desired value.
>> +@item M_ARENA_MAX
> 
> Missing blank line.
> 
> Otherwise, the content looks OK to me from a technical point of view.

Thanks, I'll fix up formatting comments from Rical and push this.

Siddhesh