From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59919 invoked by alias); 27 Feb 2020 22:45:59 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 59911 invoked by uid 89); 27 Feb 2020 22:45:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 5/7] ldbl-128ibm-compat: enforce ibm128 on compat tests To: Tulio Magno Quites Machado Filho , "Paul E. Murphy" , libc-alpha@sourceware.org References: <20200214161051.32579-1-murphyp@linux.vnet.ibm.com> <20200214161051.32579-6-murphyp@linux.vnet.ibm.com> <87zhd3u5n7.fsf@linux.ibm.com> From: Paul E Murphy Message-ID: Date: Thu, 27 Feb 2020 22:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87zhd3u5n7.fsf@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg01048.txt.bz2 On 2/27/20 2:39 PM, Tulio Magno Quites Machado Filho wrote: > "Paul E. Murphy" writes: > >> For lack of a more comprehensive solution, tack on the ibm128 ABI >> compiler options for the totalorder{,mag}l compat tests which exist >> prior to enabling this feature. >> --- >> sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile >> index e40ae08469..af8027cf0e 100644 >> --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile >> +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile >> @@ -270,6 +270,7 @@ tests-internal += tst-ibm128-error tst-ieee128-error >> tests-internal += tst-ibm128-efgcvt tst-ieee128-efgcvt >> >> $(objpfx)tst-ieee128-efgcvt: gnulib-tests += $(f128-loader-link) >> +$(objpfx)tst-ldbl-efgcvt: gnulib-tests += $(f128-loader-link) I agree and missed this when refactoring patches. It has been moved into a separate patch. > LGTM, but I think this test should mentioned in the commit message too. > > Reviewed-by: Tulio Magno Quites Machado Filho >