From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by sourceware.org (Postfix) with ESMTPS id 3EC6938582B7 for ; Mon, 11 Sep 2023 13:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3EC6938582B7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ot1-x334.google.com with SMTP id 46e09a7af769-6befdb1f545so3417904a34.3 for ; Mon, 11 Sep 2023 06:11:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694437876; x=1695042676; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=PwQbJRwlR404VpWFPfk6YCSGC8xR35enEfJDmSIUy3I=; b=joYYv/fEoddm5gWJ7Le2jU999KhyuU04bSZQ2ZL2/iGzwuI1fu6UJLXeUp+JAtpI3C l8LuV0Jn/vg57WWFayFH+QWliq2YOrzKutsqIF5IzkVnYj4HNLziqqQuqYfg3rh1NJCV h+ENF96OAZCX2SKkMxqnuJVn8Ilc4ytxd1fhvedxVU1pGGY3WnGDmkgrhEEbngNx4Dut d0zbohqhfLh3qsYO5p0WtecKBBC+WDd7f8CT3sy/acJ0VqEB6xMbzJ8SIqIXaz8uLbT3 XwfTuYgL+bGaT23qyymTbVNVe0kLH0a1ULVgaCetGM0BQJOrQGm8FwbtfFnZP8qO3l2K JPqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694437876; x=1695042676; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PwQbJRwlR404VpWFPfk6YCSGC8xR35enEfJDmSIUy3I=; b=UdbExOb08ZehT6v5qPT1nL8USdff/Xz1ohqKUB+Uy6UPUP0q+8p26knqheva0OJMYU T28CU24KN2RBkmS8pq6fARbCgGDL9Oo+weh7AqBtj3mIKRsXcJV1RyrJv6m9yk1CDdza JMLf4jPPa/e5qBH5aaKjXIUnozdqvxFJWZlvugIw0p54a8qbg2gRjVgAQU/5Q+fCdO2U 6D7MVKvuGeehAPyJPJiNFebIMktnHPyPE1K1j5eCoyx50TN0dDCjuenGq8NVv/7gxb8e /KqGdx8d3spZ5YjWp05ofwiUfJb9Qb2bHoX2Y4Go+Vvxk42VDX8d5jivrLGYPdn3hraG MTkA== X-Gm-Message-State: AOJu0YyW6jsqC9gnnlmzEXNNxJek5kFHneVBRepKqnal7sjJ5K4ilKJI xn5Kr1I+jDnauxNdLfFj+ZaR9Q== X-Google-Smtp-Source: AGHT+IGvZf/agTFhAO2OWzqnAfhgg9B0wItPWi0XeicIOcLuqavihkQWdErg2197v6NZreLvCa8DDQ== X-Received: by 2002:a9d:65d5:0:b0:6b9:b096:2617 with SMTP id z21-20020a9d65d5000000b006b9b0962617mr9925519oth.14.1694437876449; Mon, 11 Sep 2023 06:11:16 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:91cb:1977:7e4f:e638:7fad? ([2804:1b3:a7c0:91cb:1977:7e4f:e638:7fad]) by smtp.gmail.com with ESMTPSA id q19-20020a05683033d300b006b94a14b52asm3053256ott.9.2023.09.11.06.11.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Sep 2023 06:11:15 -0700 (PDT) Message-ID: Date: Mon, 11 Sep 2023 10:11:12 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH] io: Do not implement fstat with fstatat Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: Mateusz Guzik , Linus Torvalds References: <20230905203421.2127750-1-adhemerval.zanella@linaro.org> <87ledjxc33.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87ledjxc33.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 06/09/23 17:48, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> diff --git a/sysdeps/unix/sysv/linux/fstat64.c b/sysdeps/unix/sysv/linux/fstat64.c >> index 124384e57f..a7f4935a01 100644 >> --- a/sysdeps/unix/sysv/linux/fstat64.c >> +++ b/sysdeps/unix/sysv/linux/fstat64.c > >> int >> __fstat64_time64 (int fd, struct __stat64_t64 *buf) >> { >> +#if !FSTATAT_USE_STATX >> +# if XSTAT_IS_XSTAT64 >> +# ifdef __NR_newfstatat >> + /* 64-bit kABI, e.g. aarch64, ia64, powerpc64*, s390x, riscv64, and >> + x86_64. */ >> + return INLINE_SYSCALL_CALL (fstat, fd, buf); > > It's a bit suspicious to check for __NR_newfstatat an then use fstat. > Could you add a comment to explain this? > > Surprisingly it compiles on all architectures. I used the same fstatat logic, but using __NR_fstat should be fine. It build fine because for the affected architectures, newfstatat was added for archs that already supported fstat. > > Thanks, > Florian >