From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94340 invoked by alias); 7 Feb 2018 15:07:09 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 94331 invoked by uid 89); 7 Feb 2018 15:07:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE,SPF_HELO_FAIL,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Subject: Re: [PATCH 3/3] Refactor atfork handlers To: Adhemerval Zanella References: <1518008967-8310-1-git-send-email-adhemerval.zanella@linaro.org> <1518008967-8310-3-git-send-email-adhemerval.zanella@linaro.org> Cc: libc-alpha@sourceware.org From: Florian Weimer Message-ID: Date: Wed, 07 Feb 2018 15:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1518008967-8310-3-git-send-email-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-02/txt/msg00252.txt.bz2 On 02/07/2018 02:09 PM, Adhemerval Zanella wrote: > + for (size_t i = 0; i < fork_handler_list_size (&fork_handlers); i++) > + if (fork_handler_list_at (&fork_handlers, i)->dso_handle == dso_handle) > + { > + fork_handler_list_remove (&fork_handlers, i); > + break; > + } I think there can be multiple fork handlers for one dso_handle, and this loop only removes one of them. Thanks, Florian