From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by sourceware.org (Postfix) with ESMTP id 71C35389442F for ; Wed, 7 Apr 2021 00:21:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 71C35389442F Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-548-BMYyYzgkPwiJXlL6J_afIg-1; Tue, 06 Apr 2021 20:21:14 -0400 X-MC-Unique: BMYyYzgkPwiJXlL6J_afIg-1 Received: by mail-qv1-f70.google.com with SMTP id s8so4490400qve.16 for ; Tue, 06 Apr 2021 17:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=OGyzs6+F1/c6aSX2Hnp8Vkjio0N3aB4R9LjVoHtcqgA=; b=sW/b+xwDn9fz3BXZU3kRZEjVTECPwjnAyX73pkKOuTvmQGIu1m8XafJSDm2JSGrBY8 qAaixok7ztjDblaN8gaOp2NXW6Y6q5pAf0e7l0n4z7LslFEsdsHJHgGw5wShzPzYw5f5 UT9ljEGXNzy2RAzeuXteRNYn0EPIzeBr0TkhVVdPNieotzAJ060HEpNPSyIJ7ahFVHr3 RCVcH000ko8OVMoRCWMPv8j9B/ArUMGrhMoWfOICQWNvpQaGKh7mgpqrT3UN5BKJHUzP uRql37zSMHgTmYPVVNnlOuhL8cd5brvw4eR/MJV3K9PjKSsKVV7zhu82fOm+BO1t9qPA 622g== X-Gm-Message-State: AOAM5338IKJ8UWwgyZBavpTORe86fRtZB56McO9/ut6NQxVH6DSF5kTx xchuQuQMMzw6chMACJs7iNWpzZbgGd5MC0B7LObr3uE7RYvtgHzpSZCF8zuGDRmXxyfY5A3eCed 86xrFf8rX38AG9j0uoD5FfPiMA883AKx8CV60LRVLDovSdP+U6jCUkASivvuiioJI4o2+3g== X-Received: by 2002:a05:622a:204:: with SMTP id b4mr471294qtx.373.1617754874261; Tue, 06 Apr 2021 17:21:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpW96RIYQ6k6dPsahD7uPEFAh2reU6QYcharQpi4M0qLNy0gq0tZp5qwg2rkgWzM8PXqARmg== X-Received: by 2002:a05:622a:204:: with SMTP id b4mr471282qtx.373.1617754873971; Tue, 06 Apr 2021 17:21:13 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id v66sm17355484qkd.113.2021.04.06.17.21.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Apr 2021 17:21:13 -0700 (PDT) Subject: Re: [PATCH] malloc: Run tst-malloc-stats-cancellation via test-driver.c To: Arjun Shankar , libc-alpha@sourceware.org References: <20210406223947.GA39160@aloka.lostca.se> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Tue, 6 Apr 2021 20:21:12 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210406223947.GA39160@aloka.lostca.se> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Apr 2021 00:21:18 -0000 On 4/6/21 6:39 PM, Arjun Shankar wrote: > From: Arjun Shankar > > This allows the test to time out in case it hangs. > --- > I ran into an instance of this test hanging when building glibc on Fedora > Rawhide for armv7hl. I am still investigating the cause of that but, in > the meanwhile, this change is still worth making. > LGTM. Reviewed-by: Carlos O'Donell > malloc/tst-malloc-stats-cancellation.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/malloc/tst-malloc-stats-cancellation.c b/malloc/tst-malloc-stats-cancellation.c > index 9a8f475830..725cad6498 100644 > --- a/malloc/tst-malloc-stats-cancellation.c > +++ b/malloc/tst-malloc-stats-cancellation.c > @@ -91,8 +91,8 @@ buffer_threadproc (void *argp) > } > > > -int > -main (void) > +static int > +do_test (void) > { > int result = 0, err, real_stderr_fd, bufpipe[2]; > pthread_t t_thr, b_thr; > @@ -214,3 +214,5 @@ main (void) > } > return result; > } > + > +#include > -- Cheers, Carlos.