From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
libc-alpha@sourceware.org
Cc: commit-hurd@gnu.org
Subject: Re: [PATCH] stdlib: Fix BZ #26241 testcase on GNU/Hurd
Date: Wed, 24 Mar 2021 10:04:51 -0300 [thread overview]
Message-ID: <c3b0d5fd-28d7-a44c-6fde-7ec793742418@linaro.org> (raw)
In-Reply-To: <20210324003822.341322-1-samuel.thibault@ens-lyon.org>
On 23/03/2021 21:38, Samuel Thibault wrote:
> GNU/Hurd's readlink system call is partly implemented in userspace, which
> also allocates a buffer on the stack for the result, and thus needs one
> more path.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> stdlib/tst-canon-bz26341.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/stdlib/tst-canon-bz26341.c b/stdlib/tst-canon-bz26341.c
> index 6d054596b5..0ddd9aed15 100644
> --- a/stdlib/tst-canon-bz26341.c
> +++ b/stdlib/tst-canon-bz26341.c
> @@ -72,10 +72,11 @@ do_realpath (void *arg)
> If realpath uses more than 2 * PATH_MAX plus some slack it will trigger
> a stackoverflow. */
>
> + const size_t syscall_usage = 1 * PATH_MAX + 1024;
Could you also add a comment from where this come from on the description
above?
> const size_t realpath_usage = 2 * PATH_MAX + 1024;
> const size_t thread_usage = 1 * PATH_MAX + 1024;
> size_t stack_size = support_small_thread_stack_size ()
> - - realpath_usage - thread_usage;
> + - syscall_usage - realpath_usage - thread_usage;
> char stack[stack_size];
> char *resolved = stack + stack_size - thread_usage + 1024;
>
>
next prev parent reply other threads:[~2021-03-24 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 0:38 Samuel Thibault
2021-03-24 13:04 ` Adhemerval Zanella [this message]
2021-03-24 20:59 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3b0d5fd-28d7-a44c-6fde-7ec793742418@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=commit-hurd@gnu.org \
--cc=libc-alpha@sourceware.org \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).