From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 97073 invoked by alias); 21 Feb 2020 14:34:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 97063 invoked by uid 89); 21 Feb 2020 14:34:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=companion, quietly X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH 4/7] ldbl-128ibm-compat: fixup subdir location of several funcs To: libc-alpha@sourceware.org References: <20200214161051.32579-1-murphyp@linux.vnet.ibm.com> <20200214161051.32579-5-murphyp@linux.vnet.ibm.com> From: Paul E Murphy Message-ID: Date: Fri, 21 Feb 2020 14:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200214161051.32579-5-murphyp@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00917.txt.bz2 While it was tested against build-many-glibcs.py, this doesn't actually build yet. I tested this locally for whatever that is worth. Pushed typo fix in comments: "it's" -> "its". On 2/14/20 10:10 AM, Paul E. Murphy wrote: > We want to ensure that if a second file is built to support > ieee128 long double, we built it's companion implementation > with ibm128 long double. The shared object versions of these > files build correctly because the aliasing is sufficiently > complex to prevent the redirects from applying when defining > them. > > However, this does not prevent the static object variants > from becoming quietly broken due to redirects. This is > intentionally avoided by marking such objects to be built > with -mabi=ibmlongdouble. > > Shuffle the misplaced routines to build against the subdir > which defines the needed symbols. > --- > sysdeps/ieee754/ldbl-128ibm-compat/Makefile | 32 ++++++++++----------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile > index 2dceb658e7..e40ae08469 100644 > --- a/sysdeps/ieee754/ldbl-128ibm-compat/Makefile > +++ b/sysdeps/ieee754/ldbl-128ibm-compat/Makefile