From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117974 invoked by alias); 18 Aug 2017 17:43:11 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 117951 invoked by uid 89); 18 Aug 2017 17:43:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 38D7F4A6E6 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=fweimer@redhat.com Subject: Re: [PATCH 1/3] Mark internal grp/pwd/shadow functions with attribute_hidden [BZ #18822] To: "H.J. Lu" References: <20170818162752.GA21741@gmail.com> Cc: GNU C Library From: Florian Weimer Message-ID: Date: Fri, 18 Aug 2017 17:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170818162752.GA21741@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00903.txt.bz2 On 08/18/2017 06:27 PM, H.J. Lu wrote: > (__getpwnam_r): Likewise. Doesn't this break building nscd? In general, I think we use libc_hidden_proto/libc_hidden_def for this, so that the libc-internal references turn into local calls. Thanks, Florian