From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by sourceware.org (Postfix) with ESMTPS id C1CE23858D1E for ; Fri, 30 Sep 2022 11:24:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1CE23858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-vs1-xe33.google.com with SMTP id m65so4424691vsc.1 for ; Fri, 30 Sep 2022 04:24:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=edq+EqobIWEX7nK/+PKOB4ZcgYfmJSSeMd7bwRiFjwY=; b=fGz9CF16B666x6INWHZGYuKO1kYlngB/6PuZK/yxsntYKo1uJbo2Ji8mWDC4OZUjEe c32g7h9ejpx5TKCjSks/DmS9C7bFiR0k09Rcsb3pKnBsepJi0P/pptjSJE++z7PqJOi0 s9D4xqURT2RXjrGabNFWETYrFTqT9aHFreuWfggf//oquOd36VPLgyouNZ1UgeT63yOs KY4BQos6f25phv915xDx/dPwW5Rzazj+MT5E4RaamyS3nGrXovy4BKvFhKPuvkWy+Nv8 JNlVZWNaCSGe1bRYhT7jRe7HFP8OiTk1JJSKJLzoSavhq8SpDDItRkmczMtmuoIGE8eN Xqrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=edq+EqobIWEX7nK/+PKOB4ZcgYfmJSSeMd7bwRiFjwY=; b=OBKkoP6SVt1FqysMsjQjBTGp9v+bxUziQVTmZrl06jVf+JMEn8+hMPoWpVjYfhrc9O nVyOItCeghft+e5Dm8tEyNAZeJpCw3PdPtsTOo/yBN6N6mLecQ2vUyMeNlFUKO9ClY8S Y3EpYB8v/FOPnduocrRbKlzaPwxzYf2T6o6nV7Oj3Tax3fdrMCSGWv4q8vR7L5L0TAgZ 2KuaJRigs5qL9kHZTO5hEfWhHa6eQ3HI8kQHTkeFD5S1SPFdfdqadsncYFgk/wpTkhPH mNNob3UwHGZ2Zxcn+WnkFgqtlqYJat4LnrLymLSyZq7R9ygKpgStH3IlGmrI8G3MDwnP 3j0g== X-Gm-Message-State: ACrzQf2/3cfh9+lrB8gm1Tr5c4i3hK3DPlX8dB2KGglK2T0ptFuUQ1i7 vl1/cITFPr5KFnsNh/4HPSQV/ySCujfQI9ok X-Google-Smtp-Source: AMsMyM5jSVCsqbB2Gygmm4oC8+HTwI0Q6GLc060hbiotUsQW41Dv07wrI8wfPb2M5ppjG5stlNpoJA== X-Received: by 2002:a05:6102:2826:b0:39b:d63:87bb with SMTP id ba6-20020a056102282600b0039b0d6387bbmr3942165vsb.62.1664537044087; Fri, 30 Sep 2022 04:24:04 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:3736:5474:7f48:dc74:6616? ([2804:1b3:a7c2:3736:5474:7f48:dc74:6616]) by smtp.gmail.com with ESMTPSA id k10-20020ac5ccea000000b003a2d2007520sm1514725vkn.30.2022.09.30.04.24.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 30 Sep 2022 04:24:03 -0700 (PDT) Message-ID: Date: Fri, 30 Sep 2022 08:24:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350) Content-Language: en-US To: Szabolcs Nagy , Florian Weimer , libc-alpha@sourceware.org References: <20220127201542.2306657-1-adhemerval.zanella@linaro.org> <20220127201542.2306657-3-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/09/22 08:05, Szabolcs Nagy wrote: > The 09/30/2022 11:47, Szabolcs Nagy via Libc-alpha wrote: >> The 01/27/2022 17:15, Adhemerval Zanella via Libc-alpha wrote: >>> The __convert_scm_timestamps only updates the control message last >>> pointer for SOL_SOCKET type, so if the message control buffer contains >>> multiple ancillary message types the converted timestamp one might >>> overwrite a valid message. >>> >>> The test checks if the extra ancillary space is correctly handled >>> by recvmsg/recvmmsg, where if there is no extra space for the 64-bit >>> time_t converted message the control buffer should be marked with >>> MSG_TRUNC. It also check if recvmsg/recvmmsg handle correctly multiple >>> ancillary data. >>> >>> Checked on x86_64-linux and on i686-linux-gnu on both 5.11 and >>> 4.15 kernel. >>> >>> Co-authored-by: Fabian Vogt >> >> note: the time64 recvmsg test started to fail on 32bit >> arm after i updated my aarch64 kernel to 5.18 > > sorry the kernel is > Linux 8a7948402d35 5.15.0-48-generic #54~20.04.1-Ubuntu SMP Thu Sep 1 16:20:53 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux I just check on exactly same kernel (ubuntu 22) on a aarch64 VM and I could not reproduce it: $ uname -a Linux ubuntu-aarch64 5.15.0-48-generic #54-Ubuntu SMP Fri Aug 26 13:31:33 UTC 2022 aarch64 aarch64 aarch64 GNU/Linux $ file socket/tst-socket-timestamp socket/tst-socket-timestamp: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped $ file socket/tst-socket-timestamp-time64 socket/tst-socket-timestamp-time64: ELF 32-bit LSB pie executable, ARM, EABI5 version 1 (SYSV), dynamically linked, interpreter /lib/ld-linux-armhf.so.3, for GNU/Linux 3.2.0, with debug_info, not stripped $ ./testrun.sh socket/tst-socket-timestamp $ ./testrun.sh socket/tst-socket-timestamp-time64 $ I used gcc 12.1.1, maybe it is a compiler issue?