From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: libc-alpha@sourceware.org
Subject: Re: [PATCH] posix: glob, glob64 should not be declared __THROW [BZ #27522]
Date: Fri, 5 Mar 2021 10:05:42 -0300 [thread overview]
Message-ID: <c4ae0efb-f1d1-3bed-c59f-0c7a85ee69fc@linaro.org> (raw)
In-Reply-To: <87h7lpg3nk.fsf@oldenburg.str.redhat.com>
On 05/03/2021 09:56, Florian Weimer via Libc-alpha wrote:
> These functions invoke callbacks with GLOB_ALTDIRFUNC, so they
> are not leaf functions (as implied by _THROW). Use __THROWNL
> and __REDIRECT_NTHNL to express this.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> posix/glob.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/posix/glob.h b/posix/glob.h
> index 71c6b84a8a..b5686600c7 100644
> --- a/posix/glob.h
> +++ b/posix/glob.h
> @@ -145,15 +145,15 @@ typedef struct
> #if !defined __USE_FILE_OFFSET64
> extern int glob (const char *__restrict __pattern, int __flags,
> int (*__errfunc) (const char *, int),
> - glob_t *__restrict __pglob) __THROW;
> + glob_t *__restrict __pglob) __THROWNL;
>
> /* Free storage allocated in PGLOB by a previous `glob' call. */
> extern void globfree (glob_t *__pglob) __THROW;
> #else
> -extern int __REDIRECT_NTH (glob, (const char *__restrict __pattern,
> - int __flags,
> - int (*__errfunc) (const char *, int),
> - glob_t *__restrict __pglob), glob64);
> +extern int __REDIRECT_NTHNL (glob, (const char *__restrict __pattern,
> + int __flags,
> + int (*__errfunc) (const char *, int),
> + glob_t *__restrict __pglob), glob64);
>
> extern void __REDIRECT_NTH (globfree, (glob_t *__pglob), globfree64);
> #endif
> @@ -161,7 +161,7 @@ extern void __REDIRECT_NTH (globfree, (glob_t *__pglob), globfree64);
> #ifdef __USE_LARGEFILE64
> extern int glob64 (const char *__restrict __pattern, int __flags,
> int (*__errfunc) (const char *, int),
> - glob64_t *__restrict __pglob) __THROW;
> + glob64_t *__restrict __pglob) __THROWNL;
>
> extern void globfree64 (glob64_t *__pglob) __THROW;
> #endif
>
prev parent reply other threads:[~2021-03-05 13:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 12:56 Florian Weimer
2021-03-05 13:05 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4ae0efb-f1d1-3bed-c59f-0c7a85ee69fc@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).