public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
	libc-alpha@sourceware.org, Andreas Schwab <schwab@suse.de>
Subject: Re: [PATCH] libio: Free backup area when it not required (BZ#22415)
Date: Thu, 14 Dec 2017 15:36:00 -0000	[thread overview]
Message-ID: <c4d62461-5e31-6b8e-dde4-e929d4038b58@linaro.org> (raw)
In-Reply-To: <2c2665b7-7cee-6616-f693-82bebf8fbc42@redhat.com>



On 14/12/2017 09:57, Florian Weimer wrote:
> On 11/29/2017 02:39 PM, Adhemerval Zanella wrote:
>> Some libio operations fail to correctly free the backup area (created
>> by_IO_{w}default_pbackfail on unget{w}c) resulting in either invalid
>> buffer free operations or memory leaks.
>>
>> For instance, on the example provided by BZ#22415 a following
>> fputc after a fseek to rewind the stream issues an invalid free on
>> the buffer.
> 
> Do we have to treat this as a security bug?  I don't think so, but I'd still like a second opinion.
> 
> Thanks,
> Florian

I am not well versed in exploit crafting, so how do we usually handle
invalid free on user provided buffers?

  reply	other threads:[~2017-12-14 15:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 13:40 Adhemerval Zanella
2017-12-12 17:04 ` Adhemerval Zanella
2017-12-12 17:23 ` Andreas Schwab
2017-12-14 11:57 ` Florian Weimer
2017-12-14 15:36   ` Adhemerval Zanella [this message]
2017-12-14 15:45     ` Florian Weimer
2017-12-15 11:11       ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4d62461-5e31-6b8e-dde4-e929d4038b58@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).