From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc2c.google.com (mail-oo1-xc2c.google.com [IPv6:2607:f8b0:4864:20::c2c]) by sourceware.org (Postfix) with ESMTPS id D2437385841C for ; Tue, 8 Mar 2022 16:31:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D2437385841C Received: by mail-oo1-xc2c.google.com with SMTP id q1-20020a4a7d41000000b003211b63eb7bso4512996ooe.6 for ; Tue, 08 Mar 2022 08:31:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=xhUrrShngDgGXOTu3Xg7EnjXJC+nUNSso+zjV8qCghg=; b=MJIqPVexK55yQrvqTR8GIKtvH7USIBqRrWOuDJ00+4+QJOf2Sux1fPG1wphb75jtq/ kYq4Vw4N652+eCdiZQeY3e0LSJvsia7mCoai9O6ZK/XtmiHfqcLhabYFuC17nq7Hze1x g+UMhj6DW/kZ3BFcOhsxhWc5wIN6UjEvBPfZSv4zWkFJdlAvJn3TyjHzw/gjs4HofdsQ /sckyH/YIiFW5awkCnfhLE1PRPfok7iOARIVvk/moWjlZePVK8WNpTCPmltQ9D5O9U6x lxtSGYXUzAPM7m55z/2zLWgbznBPOx/gikwuGPWdqg+en9MFZBLeEXky2SDvD2CZU5up tHDQ== X-Gm-Message-State: AOAM530+DLGRO0JiSEe473U/li2l2Y5eQyBtq7iioAW8ofcMaOD7Rxw4 AL5r8EuKkz2yfksrWbCfpkQEnDjGRp9u4g== X-Google-Smtp-Source: ABdhPJy6C/hbbfs/G0OzoCVSu3/TH5GIr0O/z2vZ2/H0EZvVE4JraJNTWDYEnr+xRuiHlOvgnbH//g== X-Received: by 2002:a05:6870:344d:b0:da:b3f:3269 with SMTP id i13-20020a056870344d00b000da0b3f3269mr2914861oah.281.1646757080182; Tue, 08 Mar 2022 08:31:20 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:2dcb:7122:6b3a:c840:afc7? ([2804:431:c7ca:2dcb:7122:6b3a:c840:afc7]) by smtp.gmail.com with ESMTPSA id p14-20020a056830304e00b005b246b673f2sm1976393otr.71.2022.03.08.08.31.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Mar 2022 08:31:19 -0800 (PST) Message-ID: Date: Tue, 8 Mar 2022 13:31:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC][PATCH] * bits/confname.h: Define _CS_POSIX_V7_THREADS_CFLAGS, _CS_POSIX_V7_THREADS_LDFLAGS Content-Language: en-US From: Adhemerval Zanella To: =?UTF-8?Q?=c3=89rico_Nogueira?= , libc-alpha@sourceware.org Cc: elfutils-devel@sourceware.org, Rich Felker References: <20201026233303.16034-1-ericonr@disroot.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Mar 2022 16:31:22 -0000 On 08/03/2022 13:29, Adhemerval Zanella wrote: > > > On 26/10/2020 20:33, Érico Nogueira via Libc-alpha wrote: >> From: Érico Rolim >> >> I would like to add these enums in order to conform to the POSIX >> specification: https://www.man7.org/linux/man-pages/man0/unistd.h.0p.html >> >> This change also helps musl-libc, since they want to have these defines >> with the same values as glibc. >> >> I tried to add them for the bits/confname.h and >> conform/data/unistd.h-data files following the example of the other >> values, but didn't know how to plug them into the confstr / __sysconf >> implementations. > > I think since we do not export _SC_POSIX_THREADS and now that libpthread > symbols were all moved to libc, there is no need return the libpthread > for LDFLAGS. However it requires to be handled on confstr and getconf: > > diff --git a/posix/confstr.c b/posix/confstr.c > index 6e3c264462..95fb0f6abc 100644 > --- a/posix/confstr.c > +++ b/posix/confstr.c > @@ -249,6 +249,11 @@ __confstr (int name, char *buf, size_t len) > /* GNU libc does not require special actions to use LFS functions. */ > break; > > + case _CS_POSIX_V7_THREADS_CFLAGS: > + case _CS_POSIX_V7_THREADS_LDFLAGS: > + /* GNU libc does not require special actions to use thread functions. */ > + break; > + > case _CS_GNU_LIBC_VERSION: > string = "glibc " VERSION; > string_len = sizeof ("glibc " VERSION); > diff --git a/posix/getconf.c b/posix/getconf.c > index a1adbc4b50..6a5363ad49 100644 > --- a/posix/getconf.c > +++ b/posix/getconf.c > @@ -310,6 +310,8 @@ static const struct conf vars[] = > { "POSIX_V7_LPBIG_OFFBIG_LDFLAGS", _CS_POSIX_V7_LPBIG_OFFBIG_LDFLAGS, CONFSTR }, > { "POSIX_V7_LPBIG_OFFBIG_LIBS", _CS_POSIX_V7_LPBIG_OFFBIG_LIBS, CONFSTR }, > { "POSIX_V7_LPBIG_OFFBIG_LINTFLAGS", _CS_POSIX_V7_LPBIG_OFFBIG_LINTFLAGS, CONFSTR }, > + { "POSIX_V7_THREADS_CFLAGS", _CS_POSIX_V7_THREADS_CFLAGS, CONFSTR }, > + { "POSIX_V7_THREADS_LDFLAGS", _CS_POSIX_V7_THREADS_LDFLAGS, CONFSTR }, > > { "_POSIX_ADVISORY_INFO", _SC_ADVISORY_INFO, SYSCONF }, > { "_POSIX_BARRIERS", _SC_BARRIERS, SYSCONF }, > > Also now that we do not require a copyright assignment, you just need to add > a sign-off on the email submission. > Also, reference the BZ#25003 [1] on title. https://sourceware.org/bugzilla/show_bug.cgi?id=25003