From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 2D6473858D37 for ; Mon, 18 Mar 2024 12:19:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D6473858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D6473858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710764391; cv=none; b=mp/y9ohnhEHdkcaMrCL1bSWP2Y8CjhzOPLBSOerqyvFrnNi1ashuK3rmX/6l7ClI616oywLyHhywQQ+pjpQ7hdwnmdrfpWaGUns6BU4ZFIIVJH4+qwPLoY7TTcmdt7m/uzllWnKmyHSO3K1D0/frkygww5CTIftJm5S04ibjW6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710764391; c=relaxed/simple; bh=XUEIrfw0JLFUxgcjY7bS5RpBR5GUj0HYUV3/L6oQQCQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LS5NLDA+5qgVMkAeaK9jdhsTWfCCdb6Zojou+ti+XYBsvNF9PvIRFPzqq3r28RAgzML/UF6AnNn7mJAyZGQ0o8nJd82exDq+gpo4ppHUooPhLsdyeB9O0arOQ0tQ+ZelAqEAdVgjQCOgcq3lvbNgBek1ZpU34q/VjREo8caxkTk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-1def2a1aafaso16029945ad.3 for ; Mon, 18 Mar 2024 05:19:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710764388; x=1711369188; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=3KcWbc+FK3NQdQWq0K6c3nDmlRhFGsE2Tk1i7VekPKk=; b=tkrzrmBfPN4grpTI3g+83eE/GZOifBsivFESzWOeU3e7FUToYf2PfXHWY0zRqnAcFa 15ZPrO9RhLtK4LezlxAjPDBAOK7D3TmPT5N4FOh5mHFWeFvtOs3qltbAA2Xfny5PxHUH imtBf9/AOmYeJP7QaFdSQlPjsNv01klikXZPxeExrFxCSAGrg+4rJvopZ2pE+2F/ypKb S1UC2DWaJIljhrMfJMT48NSFGg6cOfe6SIqqlf6Ud41nPKwhmm9ibx9LXOWGq91ydfCt pZ/eYQWDtZpLThqrGKBaSStBVVdYeaisE2M+CC+3s9CijgzA4xj0ip3qZlXGANKNiiWH /pEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710764388; x=1711369188; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3KcWbc+FK3NQdQWq0K6c3nDmlRhFGsE2Tk1i7VekPKk=; b=a/tgFkU50yHEN7FBGBMp8TcVHH9e5SJiUoJYQ9/DJ4Q6fZs3swTtfCIB7xZF0bq+eB QQ3ZXdRg0d4nRO1O0OOnoZQu2btXM2GHT74LREdPHA9Te5Yc7kV4gjiV4q+t854ou/y6 qqx0QBIgyOZP4E4ibr2Sl3tLTqJsfDRueri6ecmsXVGrKE5j4eQkANO3t+IBQDt4qbHx gEpmD1ISCIVXhTUVbhPOwNEOQ6tgri60o7kVcgFhLKCYoThvovCk+moadc6MFYfyPB4a 5E8onrOG4V+pJcWeGeXNWFLPOaOJAzkyFXJa9qHWFkI3ZP+cjv7oemaitRuKJbAnRibD TwKw== X-Gm-Message-State: AOJu0YxV7D0vSRRPO261tua4g6Nnbyi/Xi4dlY3GRxwHVOVPuJTfgpwX kY97m3SDHUxIM/kczDub11nOnwr4ZdHebxdd/xBS1+CGLX7ASMqqeoVRddwJczE= X-Google-Smtp-Source: AGHT+IH8OEECBEot36i8paKZxG40TZxXy8D0JdnZCJQnKgDE/1ydrbStW9ou7ccqhiU9bDQ0Efneug== X-Received: by 2002:a17:902:c952:b0:1dd:6765:103 with SMTP id i18-20020a170902c95200b001dd67650103mr11310381pla.48.1710764387976; Mon, 18 Mar 2024 05:19:47 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:8dfd:69e5:10f4:c28c:8fbb? ([2804:1b3:a7c2:8dfd:69e5:10f4:c28c:8fbb]) by smtp.gmail.com with ESMTPSA id m12-20020a1709026bcc00b001dc05535632sm1685453plt.170.2024.03.18.05.19.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Mar 2024 05:19:47 -0700 (PDT) Message-ID: Date: Mon, 18 Mar 2024 09:19:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] Always define __USE_TIME_BITS64 when 64 bit time_t is used Content-Language: en-US To: Andreas Schwab Cc: libc-alpha@sourceware.org, DJ Delorie References: <20240318114259.164673-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 18/03/24 09:07, Andreas Schwab wrote: > On Mär 18 2024, Adhemerval Zanella wrote: > >> diff --git a/manual/maint.texi b/manual/maint.texi >> index 89da704f45..1c441eb5f7 100644 >> --- a/manual/maint.texi >> +++ b/manual/maint.texi >> @@ -491,6 +491,10 @@ derived as in the dual-time configuration case, and which expands to >> the symbol's name. For instance, the macro @code{__clock_gettime64} >> expands to @code{clock_gettime}. >> >> +When @code{__TIMESIZE == 64} is set, @theglibc{} will also define the > > When @code{__TIMESIZE} is set to 64, > >> +@code{__USE_TIME_BITS64}. It is used by the Linux kernel ABI to set the > > the @code{__USE_TIME_BITS64} macro. Ack. > >> diff --git a/sysdeps/generic/features-time64.h b/sysdeps/generic/features-time64.h >> index 4d38b8ba76..8fe811bd9e 100644 >> --- a/sysdeps/generic/features-time64.h >> +++ b/sysdeps/generic/features-time64.h >> @@ -17,3 +17,7 @@ >> . */ >> >> /* The generic configuration only support _TIME_BITS=32. */ >> +#define __USE_TIME_BITS64 0 > > This is supposed to be used with #ifdef, it should not be defined here. In fact, it now does not make much sense to add the generic features-time64.h header (since both macros should be explicit defined).