From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 19C2F3857016 for ; Tue, 16 May 2023 12:27:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19C2F3857016 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-39420384cc4so4602271b6e.0 for ; Tue, 16 May 2023 05:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684240020; x=1686832020; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4wKWjfUd7Ws4LBmgldpUKQ5VdUrr4usD6mRCGRaJxVY=; b=vcAymzqFsbAbHls0pp0QEwWMJ1lOphfcchfGjZ6jMtfw1U7MginZLTHMdIg2VGPbAw a+89GZzXbr8SFZMpsr18GFfYCg0t9xIqlSoqVA+BMc5hPODe5CTAS+IJd1x0GzUPOfZN PN0skJ1xKh0kAxADuRFGpARaKZUrkmPOZ78jmQfs5qlMi/jEo3TAKb7bF9qKu3triEmJ Qy+nBtGiZ8MyYpwDtEGvRJ6OQAk+xZlfJ1CamwS8577w+QMBmPiRRMvhb5JSEuhfD68R Th2jHy3AtesWCUbOW8giKQrMymXORcoqMI8rfmjRKvGT57M3YboKx3evd/b1dL/ILZa1 sYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684240020; x=1686832020; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4wKWjfUd7Ws4LBmgldpUKQ5VdUrr4usD6mRCGRaJxVY=; b=SARNM4z4HlCW4+p0B0Ma6QTL3gZc/SsKXgm/hEYjLKx7+PId62zQJ5uCrIotIa0v28 86q48driT1KnqvU9Ezp4ypDvZhk8sSV+Ap4O/77ABnpBKoDvtKo8dOGc5DLBr3iSTld3 sWPzwS+rGihBg+zhfNWLezdgQ/WvCe868is+jlObrWrI2aSaCQSmliBmniaCTjAFU/np +A4nE4VcmkTRnqKfqGisKd4T4zihducfZWxsA1d7T9bQw3lyclE6/Nzo+sSqmYyFg+JU 94tofUgBN/qEU2Px9Rnpvb+FL8jyEgR3UiB+rtIwbjYrluVhsTlfHO9+NbCM2IWWhQnj 4z4w== X-Gm-Message-State: AC+VfDzSOSwxH5ARRirIKZXu92uzr5IeRohYcisDQ2KhJX3AhcEb/bcd p1uKcmCR2yk2TuRWTmLyjx0VxyP/BEdcMdNkPWH2cQ== X-Google-Smtp-Source: ACHHUZ7LqG6tDOT0WB3fwJbFaK5V3FQlNzNrp9t9p/YMwL2dGE/sz8AWNz7BImo9NHihxHKHFtNc0g== X-Received: by 2002:aca:190d:0:b0:394:2815:5b37 with SMTP id l13-20020aca190d000000b0039428155b37mr10182077oii.30.1684240019449; Tue, 16 May 2023 05:26:59 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:c914:28b3:cbf9:a103:6f88? ([2804:1b3:a7c0:c914:28b3:cbf9:a103:6f88]) by smtp.gmail.com with ESMTPSA id y8-20020acae108000000b0038bb2f60064sm8783366oig.30.2023.05.16.05.26.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 May 2023 05:26:58 -0700 (PDT) Message-ID: Date: Tue, 16 May 2023 09:26:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: Added consensus item about sorting Makefile lines. Content-Language: en-US To: Carlos O'Donell , libc-alpha References: <8e01bbc6-4278-70f4-ca97-76732ff77771@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <8e01bbc6-4278-70f4-ca97-76732ff77771@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 16/05/23 09:01, Carlos O'Donell via Libc-alpha wrote: > Community, > > I added the following to consensus: > > https://sourceware.org/glibc/wiki/Consensus#Trivial_Bug-Fix_Changes > ~~~ > Anyone can commit a change to reformat a Makefile to use one value > per line (with trailing comment) where the variable is assigned > multiple values in one line. Such a change needs to clearly state > (in the commit message) if any code generation changes are observed > and the results of testing. The convenience script > scripts/sort-makefile-lines.py is provided to sort the lines between > the start and end markers. > ~~~ > > Please feel empowered to cleanup any Makefiles we are using. > > I'm about to commit a cleanup to the most used Makefiles that were > partially converted as each of us was added new lines. > Thanks for improve this Carlos.