public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Zack Weinberg <zackw@panix.com>, libc-alpha@sourceware.org
Cc: joseph@codesourcery.com, adhemerval.zanella@linaro.org,
	Wilco.Dijkstra@arm.com, carlos@redhat.com, schwab@suse.de
Subject: Re: [PATCH 06/10] Remove __need_list_t and __need_res_state.
Date: Wed, 10 May 2017 07:37:00 -0000	[thread overview]
Message-ID: <c5d9dab8-27f8-72f0-d07b-8e300fe4adc1@redhat.com> (raw)
In-Reply-To: <20170509154103.11973-7-zackw@panix.com>

On 05/09/2017 05:40 PM, Zack Weinberg wrote:
> +#define LOCALDOMAINPARTS	2	/* min levels in name that is "local" */
> +
> +#define RES_TIMEOUT		5	/* min. seconds between retries */
> +#define MAXRESOLVSORT		10	/* number of net to sort on */
> +#define RES_MAXNDOTS		15	/* should reflect bit field size */
> +#define RES_MAXRETRANS		30	/* only for resolv.conf/RES_OPTIONS */
> +#define RES_MAXRETRY		5	/* only for resolv.conf/RES_OPTIONS */
> +#define RES_DFLRETRY		2	/* Default #/tries. */
> +#define RES_MAXTIME		65535	/* Infinity, in milliseconds. */
> +
> +struct __res_state {
> +	int	retrans;		/* retransmition time interval */
> +	int	retry;			/* number of times to retransmit */
> +	unsigned long options;		/* option flags - see below. */
> +	int	nscount;		/* number of name servers */
> +	struct sockaddr_in
> +		nsaddr_list[MAXNS];	/* address of name server */
> +# define nsaddr	nsaddr_list[0]		/* for backward compatibility */

I suggest to keep all those #defines in <resolv/resolv.h>, purely to 
minimize recompilation if we add more macros here.  This applies to 
RES_*, LOCALDOMAINPARTS and the nsaddr macro.  MAXNS, MAXDFLSRCH, 
MAXDNSRCH can stay because we can't change them anyway.

Rest of the patch looks okay, but please verify that this does not 
affect stripped binaries.

Thanks,
Florian

  reply	other threads:[~2017-05-10  7:37 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-09 15:41 [PATCH 00/10] All of my not-yet-reviewed patches Zack Weinberg
2017-05-09 15:41 ` [PATCH 07/10] Remove __need_IOV_MAX and __need_FOPEN_MAX Zack Weinberg
2017-05-09 15:41 ` [PATCH 02/10] Suppress internal declarations for most of the testsuite Zack Weinberg
2017-05-09 21:28   ` Joseph Myers
2017-05-10 11:56     ` Zack Weinberg
2017-05-12 15:40       ` H.J. Lu
2017-05-12 16:16         ` Zack Weinberg
2017-05-12 16:26           ` H.J. Lu
2017-05-15 14:18   ` [PATCH] Move tst-mutex*8* to tests-internal Tulio Magno Quites Machado Filho
2017-05-20 13:06     ` Zack Weinberg
2017-05-22 14:21       ` Stefan Liebler
2017-05-25 17:55         ` Tulio Magno Quites Machado Filho
2017-05-09 15:41 ` [PATCH 01/10] Remove _IO_MTSAFE_IO from public headers Zack Weinberg
2017-05-09 21:11   ` Joseph Myers
2017-05-09 15:41 ` [PATCH 03/10] The bits/types/*.h treatment for stdio and wchar Zack Weinberg
2017-05-09 21:34   ` Joseph Myers
2017-05-10 11:52     ` Zack Weinberg
2017-05-20 21:05       ` Zack Weinberg
2017-05-22 14:56         ` Joseph Myers
2017-05-09 15:41 ` [PATCH 08/10] Don't install libio.h or _G_config.h Zack Weinberg
2017-05-09 15:41 ` [PATCH 09/10] Remove bits/string2.h Zack Weinberg
2017-05-09 15:41 ` [PATCH 04/10] Convert signal.h from __need macros to bits/types/ headers Zack Weinberg
2017-05-09 21:36   ` Joseph Myers
2017-05-17 17:41   ` Joseph Myers
2017-05-20 21:03     ` Zack Weinberg
2017-05-09 15:56 ` [PATCH 05/10] Remove __need macros from errno.h (__need_Emath, __need_error_t) Zack Weinberg
2017-05-09 21:38   ` Joseph Myers
2017-05-10  7:31     ` Florian Weimer
2017-05-10 11:49       ` Joseph Myers
2017-05-10 12:03         ` Florian Weimer
2017-05-11 12:15           ` Zack Weinberg
2017-05-11 14:30             ` Joseph Myers
2017-05-11 14:46               ` Zack Weinberg
2017-05-11 14:53                 ` Florian Weimer
2017-05-11 14:48             ` Florian Weimer
2017-05-11 15:26               ` Joseph Myers
2017-05-11 15:42                 ` Andreas Schwab
2017-05-11 16:10                   ` Joseph Myers
2017-05-11 17:20                     ` Andreas Schwab
2017-05-11 16:19                   ` Florian Weimer
2017-05-11 17:25                     ` Andreas Schwab
2017-05-12  6:23                       ` Florian Weimer
2017-05-15  8:11                         ` Andreas Schwab
2017-05-15  8:13                           ` Florian Weimer
2017-05-15  8:24                             ` Andreas Schwab
2017-05-15  9:08                               ` Florian Weimer
2017-05-09 15:56 ` [PATCH 06/10] Remove __need_list_t and __need_res_state Zack Weinberg
2017-05-10  7:37   ` Florian Weimer [this message]
2017-05-20 19:37     ` Zack Weinberg
2017-05-09 15:56 ` [PATCH 10/10] Remove bits/string.h Zack Weinberg
2017-05-11  0:12 ` [PATCH 00/10] All of my not-yet-reviewed patches Joseph Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5d9dab8-27f8-72f0-d07b-8e300fe4adc1@redhat.com \
    --to=fweimer@redhat.com \
    --cc=Wilco.Dijkstra@arm.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=carlos@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    --cc=zackw@panix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).