From: Carlos O'Donell <carlos@redhat.com>
To: "H.J. Lu" <hjl.tools@gmail.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3 2/3] Disable DT_RUNPATH on NSS tests [BZ #28455]
Date: Mon, 13 Dec 2021 10:29:00 -0500 [thread overview]
Message-ID: <c643ade6-6bd4-fa59-9545-4b2e21f25b2f@redhat.com> (raw)
In-Reply-To: <20211208152501.1483087-3-hjl.tools@gmail.com>
On 12/8/21 10:25, H.J. Lu wrote:
> The glibc internal NSS functions should always load NSS modules from
> the system. For testing purpose, disable DT_RUNPATH on NSS tests so
> that the glibc internal NSS functions can load testing NSS modules
> via DT_RPATH.
I agree that we should have a consistent tests that are not impacted by the specific
choices of the system toolchain. Using --disable-new-dtags is sufficient to make
this consistent. If we need *more* tests then we can add them.
This change should go in regardless of my comments in 3/3.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> This partially fixes BZ #28455.
> ---
> nss/Makefile | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/nss/Makefile b/nss/Makefile
> index bccf9f2806..757446f80a 100644
> --- a/nss/Makefile
> +++ b/nss/Makefile
> @@ -189,3 +189,11 @@ endif
>
> $(objpfx)tst-nss-files-alias-leak.out: $(objpfx)/libnss_files.so
> $(objpfx)tst-nss-files-alias-truncated.out: $(objpfx)/libnss_files.so
> +
> +# Disable DT_RUNPATH on NSS tests so that the glibc internal NSS
> +# functions can load testing NSS modules via DT_RPATH.
> +LDFLAGS-tst-nss-test1 = -Wl,--disable-new-dtags
> +LDFLAGS-tst-nss-test2 = -Wl,--disable-new-dtags
> +LDFLAGS-tst-nss-test3 = -Wl,--disable-new-dtags
> +LDFLAGS-tst-nss-test4 = -Wl,--disable-new-dtags
> +LDFLAGS-tst-nss-test5 = -Wl,--disable-new-dtags
OK. I agree that this is one solution, and that it will work.
>
--
Cheers,
Carlos.
next prev parent reply other threads:[~2021-12-13 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 15:24 [PATCH v3 0/3] Properly handle DT_RUNPATH H.J. Lu
2021-12-08 15:24 ` [PATCH v3 1/3] Add and use link-test-modules-rpath-link [BZ #28455] H.J. Lu
2021-12-13 15:32 ` Carlos O'Donell
2021-12-08 15:25 ` [PATCH v3 2/3] Disable DT_RUNPATH on NSS tests " H.J. Lu
2021-12-13 15:29 ` Carlos O'Donell [this message]
2021-12-08 15:25 ` [PATCH v3 3/3] elf: Also try DT_RUNPATH for LD_AUDIT dlopen " H.J. Lu
2021-12-13 22:07 ` Carlos O'Donell
2021-12-16 2:07 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c643ade6-6bd4-fa59-9545-4b2e21f25b2f@redhat.com \
--to=carlos@redhat.com \
--cc=hjl.tools@gmail.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).