From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2133.outbound.protection.outlook.com [40.107.115.133]) by sourceware.org (Postfix) with ESMTPS id 9ABFB3857728 for ; Fri, 16 Feb 2024 21:24:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9ABFB3857728 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9ABFB3857728 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.115.133 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708118648; cv=pass; b=R6zlOf3cEpA11l2sMetpS9BwruPfYG3T4JCTbNTepPKGGlKXZ527HtaVYQUA86GhNHLPmNyOFOQ/9rx0zGu90GG/0YCCNgrDpfztX0Q1aQNGY4KYNM3e0c89odaYC0/NjkE/nzVQLnedpCbq6OZMrL+QamztQKGf2hJY8dZ/mzk= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1708118648; c=relaxed/simple; bh=V7uLc7v7GigxxbOi+8OhF+zVfZHah1w4aoLqkMwzSyk=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=bA5dYloMRorrKnaRcd3DUaG8ij6qLBgblYmsOlLfDozzPROL/PPw1nO6gA1hAzKUahmflxV7+eNOpIFvT3VeDQNl8T6+sGrebAr399GEL53Bxmp5WtVinwicoXtMfwLpFnA8TNYcsPMehQtzXGdnXG/kaV/9Of9C905QhHk6+Ms= ARC-Authentication-Results: i=2; server2.sourceware.org ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYcchNlMLKnuPuZUQoHXEg3gSLfO9RwPwAI+2GHUlNEIBwBu+6Sl6VpGyAC5M+InKmopgsJUP8FW99HJaIbi1/dr0dq6t/NlF6njJRIrDL6tNPj4QtXUiM13oDOX5Iu+zSmT7l67izHQSEkjXojLUYoGXf5EBssJeWm6DjsTi9+S8DG4PuyZGOB69b/yOD4HjKOXSGlYGvdCBa2Zz2CHjpN5n6+MvB6bzXNwP6SF5YqRzdZSdecRX68D/6kt9KHl1zQN9qJX9aUQD0d7qavbYbZex71lUNsKPcUYu69QF1ntWWVcvDTF9LnSVyr0fgcD6fglae9jdmgfyF2cMIM0Yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RBIMcvs1sicqc66qrCAFFGatdd81j7x7nCv3dJS1X/Q=; b=Xdps803ZbP6km6WYtmNkBEzp1PP82bQGznkuuCnPhV/hFX4fqTvHg+av6enqCBkQBVcPFfY0KnNy0X9FKPFY9VfyBeBqc8Q39zJ/aYZpjB0x8saLGRk+ykEmAtZcZM2dc423p4XeIBqJ5LINpk8CGThsj6R8Mj+dyxXUeq6WoCaGN6/zOttRJx6N+X9DkZs+Pcb4E63lfgy4Dq92GF5bIhTQtzRnQ2CQ5djpSoGBz/1NLs81zHEeYrCr3HRrEsZCdi1qIyNR1JVR590s8i9IpRCCSmI0Xx84shsvGClfnndo4JmAw9MvDOPuUq5caeZJXmxvr/nxh9s+8KeVWHC6Og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RBIMcvs1sicqc66qrCAFFGatdd81j7x7nCv3dJS1X/Q=; b=t5bonu6VYWHVmOSKR13MCEd6ifyjXhPi1PHqosZx541qsaMHzugS1UOl/dUSipjP8hsULVE2TWSqXscFhpeiIEu8gyaz4Y3pC6HUX69QfkJLptrHkKAAUuEme6ka6jQDpsbn6Es/O7333YW0cwEpVoxKHtqAgSd0PiUFoHjp81gCf/pAroee73eOxRqxCbGOREs9g+7OSoPnvVUwGhRgMfzB2aHgkldNVOi622EJuWCPYQKOVl//ye7bDSGMUtkKB1RGye37NKLYgbhwwrZpqsdb9S1D2yAO1LzOvrx465zULY1EakbHt4fQ4D8kEA9DnDz16lqiP2ZBSzdtkYcIEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:24::5) by YT4PR01MB10581.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:105::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.31; Fri, 16 Feb 2024 21:24:02 +0000 Received: from YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM ([fe80::c711:83ed:d711:ea0d]) by YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM ([fe80::c711:83ed:d711:ea0d%4]) with mapi id 15.20.7292.029; Fri, 16 Feb 2024 21:24:02 +0000 Message-ID: Date: Fri, 16 Feb 2024 16:24:01 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/8] Add rseq extensible ABI support Content-Language: en-US To: DJ Delorie Cc: libc-alpha@sourceware.org, mathieu.desnoyers@efficios.com References: From: Michael Jeanson In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR0101CA0210.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:67::21) To YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:24::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQBPR0101MB5080:EE_|YT4PR01MB10581:EE_ X-MS-Office365-Filtering-Correlation-Id: 12911a2c-8d57-4751-fb0d-08dc2f359904 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UNCB2gfAfF1C/rwHzjYzRVi8OHhVYnIpvXpwUEhd0hP79tjzSM/wF5ZVU2NlDjCZ4YgqUs0tcp48SZgfDkTjUZIXWXL30lngdNuOgZoyBQr4eLguUqzFvgBNkALFrOVRHwiZBv8wksjkg8hX75henECdtQpfzFZPAGjVFV9qrFfGgDO50gRUrUCid94KK4tdNHQZ62Lz0l5fzNha3k2uPj8S23b9oVHopm0RBr9AS98aUWbiP6rkQcN6rNtzPq5dUMXq5IhIfw1jwix2+8ocMtuGbEXNwM92do/zIDeP2Ioynjj0QN6q8Dnh43BUDZ5v3HfuKOkK6orl9ENdDwBePEm0xMSkLNVp3IFTWyVWiq0R0+HU28ILbk8OKnP8rOjXWhoAqioapDFCCobc29wYHHLjw1aPFZMwvmGbsxLq+bmGfrnrNc43b29cj0bNZbzDDOjS9YgMfJKoCJgYKNgGvKzSwrL0boULZcK/K//t+nGPNzPbMCbdmrlvavZ07ST6DNLLghCmuefLLz/PDNVE/4wdQEcovlYUlIVCUcBSDb6r0//slo8EfB3RQcf5hJp8 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(346002)(39830400003)(136003)(396003)(230922051799003)(186009)(451199024)(1800799012)(64100799003)(5660300002)(66556008)(31696002)(2906002)(66476007)(8936002)(6916009)(66946007)(8676002)(4326008)(107886003)(83380400001)(2616005)(26005)(36756003)(316002)(38100700002)(41300700001)(86362001)(6506007)(6486002)(6512007)(478600001)(31686004);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WStrdjFVeVUwZ2hkcCtNOEdPeGR3RmxJOHExa2toKytCMFJTMlpwRFZoWWNP?= =?utf-8?B?RE9nZXJKRUNNNE5NQ3pmTTMxR29vWkpoK2VDOUJGOU9oaHRhenRidXZwTnBt?= =?utf-8?B?c0pDeTdCakIxMm1YWis3b0VHdVkyTHB0YU16QXhKUWl1S050TmM2OEdvQzNq?= =?utf-8?B?M0hGZ1YvVUViaEszZG1ENmZUMlg3d3FvWHFmQ0duanYxVGJUekFYcHJsMXcw?= =?utf-8?B?bUtWNVR4YXhPcHRaMHVneG9lczdGQUpvY1lRZHJzNFlocVFnRVB0Kzl0MXNv?= =?utf-8?B?TExwQlhWdzFIOVV4WHFOWVpadnlIcklNbHRRb2ppdXVETFAwcnc2ejhieXkr?= =?utf-8?B?dXo1algvck0zK1huclhOTitaZi9LS2RqWVEwbitzbXpaT0x5MVZUT09EMkxO?= =?utf-8?B?VFowN1NjMHpTZGF6azU3VTNyUTVwa25VbmxXS29DTWFSVG9JeHZoaTBSUjVi?= =?utf-8?B?QnNrK0NNWU0zMGRqZ00wdUNKeVlWeXJNL0xYMXFUdEZPbXJFdmMvMndlbkdm?= =?utf-8?B?VUxMdEYrS1N3aXJwaWh3dEZua1FZMmlkM3QvRVdRNjRQTjhYMUFZK2J0RFlt?= =?utf-8?B?MWVMZy9oSzQvd1pKanZPRVdMVUdRaEZjeWlFeFM0SW9uS05TT1R2VkVlRllr?= =?utf-8?B?MkloS2l3R3QvMzR1ckowYzNNcHAyLzdDVDNTWGF6ajdEOE5WM0ZGd2dGcjJM?= =?utf-8?B?YzRVWVhFTFpiOXc2cm5CWWJmSHZZeGwvRGVUTG44MXN2SGRWcEsrc0o0cytx?= =?utf-8?B?OHB4NG1qZnE3b3hCMkVtSldYS0hlcDZFWWF3QW1zNXp2TitJZ0k0U1E5cWZP?= =?utf-8?B?Ykw5RFlKTDVETWFGRE83bHR3c2R4SzRqTEZWVHprUVFQVlVMYlY5TitodnR1?= =?utf-8?B?TnFzWGVnemUrUEY0UDRuc2FBZXg1WGY3WEgzd21NNVJyNkgySnA3dlBIZENL?= =?utf-8?B?NlBNSC9qMHJWQ293WURGTWZRN2ZmQnAwS2ZyYVNucmlHUWFGM1lYNGJKdnQ4?= =?utf-8?B?UzhzVmUvTHFQQnZGVHV5ZHl1dzlGeVZybTc3ajVNTWtScUFjbjIzQWdxaHp4?= =?utf-8?B?K21BV2tiQ2JNbVozdE9wT0RnT2JXTFpyVTZBV2NjbFRibm1CNWNaU2JWZEpT?= =?utf-8?B?bncwUWZNbmNvYmxLZVNaUWVnUnBoYUJwWkxVMFZyRTFGZW9PUU9GMFB1SVFJ?= =?utf-8?B?Y05UeWN0bSt6Tk1rZGs0ZGFRVHpVSXllTUhsOTQ4T09walVneUEraTFpM1JJ?= =?utf-8?B?Q25iSU15VDJvVk5DNjJqT3EydUl5cHNvaGRHSDY2RmtESVpzamtQSDhhUHNQ?= =?utf-8?B?Q2JkWEJaelZtWmU0eEpNV0Y4SWN6UGdSaHdaRFZmVGV4UGVpdG5GelNZdmov?= =?utf-8?B?cWxKWmpKNldTaWwrM0JQa05VdS9Jc2N4K2NkNXlSdkpDeFRuN1dTd2g2RGlT?= =?utf-8?B?ejVNbk9KaTdDSzYzcHE5R1JmR0lsOWxnVjQ0L00vR0ZPOGFBV2pObXdlQ2RN?= =?utf-8?B?SHFueGpHQVdlbEx6YVMveG9FOS8rOGx2VzJ0OVVnNnFNMXRxOUdxQXEwMjJt?= =?utf-8?B?ZExla1ljN2JoNGUzYmpvcW5QU0lRRW05dTZvMjhGcFlmK2JDaHpENDV1eXNy?= =?utf-8?B?ZkZBQ1N3OXYzK3pBR0V4M1FDdFlHNm9POEVOZGhJYk1CbWZyeVFoQVF4d000?= =?utf-8?B?NUVwckdoQ2ZMaE9hdVEyeno3ZVU0WjJFc1lZVElWN1BIMGpQV2dDWnBrb0p4?= =?utf-8?B?VG9hY3ozUzhxeXVTYmVqZ2pZOHZJOW5OZk5Zc0g5YU8vNEp1TmRSWmZ3OFM0?= =?utf-8?B?MVA4dXZRbU94TVlYUWFUZTdmeVBBZXluNHhndENvTXpPRUhNZDVua3FEaFZx?= =?utf-8?B?dFJUZXNsMzdiV1dsSEtUcWpFRFExZVhwUm9iK0FhclkxeGQyaEJxSXo4NEE1?= =?utf-8?B?czliQ0FsbS9yWjIrcmIvMFRhOXlyZGptN0NyM2hjbU1BOXc1c00ydE5hOGh1?= =?utf-8?B?VkdZa3dJUElCa21yanNJay91aTZSOTNlMlp5Wi91SW5GZ0hkUkVXQTg0eGFI?= =?utf-8?B?ajZ5UGIyaGxLakhwZHJxMjZ5WE4rQjNhZ2ttZ3ZFbTl2UmYwZGxuTGs5MklV?= =?utf-8?Q?wR4iueMgZ/osMCzlJi3QYsGzQ?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 12911a2c-8d57-4751-fb0d-08dc2f359904 X-MS-Exchange-CrossTenant-AuthSource: YQBPR0101MB5080.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 21:24:02.7872 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dkPwk+wIROgut519YrHchcALV9bO2faUAyqOnh65l2mX8rI5eI2YK/xqyHGKNS/0QdSoM2LouwItq7/Fp8JI6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB10581 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-02-16 16 h 17, DJ Delorie wrote: > > Michael Jeanson writes: >> When rseq registration is disabled by tunable we still need to allocate >> an rseq block because application code is allowed to check for the >> registration status by reading 'rseq->cpu_id'. So in this case we >> allocate the minimum ABI size of 32. > > Ok, I admit that was confusing ;-) Yeah, I had to think for a minute to remember that, it should be documented. > >> Internally this is recorded in 'dl_tls_rseq_size' but the application >> visible '_rseq_size' is left at 0 (this happens in >> sysdeps/nptl/dl-tls_init_tp.c). > > A comment in sysdeps/nptl/dl-tls_init_tp.c after the if{} noting what > the variables would be otherwise might be useful. At least that was one > of the places I looked at when trying to figure this out. Ack. > >> I'll try making this more clear with additional comments and finding a >> name for 'rseq_size' that is not so close to '__rseq_size'. > > Perhaps "rseq_alloc_size" ? Sounds good.