From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 4D2193857C46 for ; Thu, 24 Sep 2020 01:54:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D2193857C46 Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-163-p1s_CappMMWrRcYTbNUsvQ-1; Wed, 23 Sep 2020 21:54:50 -0400 X-MC-Unique: p1s_CappMMWrRcYTbNUsvQ-1 Received: by mail-qv1-f72.google.com with SMTP id t7so1264380qvz.5 for ; Wed, 23 Sep 2020 18:54:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BsLmPXEjciqVgRZttbFucPX8nzzrw0ucEbNTafFRseQ=; b=ucAV8vAvUwH4su7gN3H6tFl7HSBDbdfjGqU6Zy89XjXeRDYnAORyTtfVzfnRknKjiQ 8JUlYaReKxXDKQzNuA9pam3DWOBbGBr2NmYFrGPlHMiDZTbJuNpSE1mzTpzMO+k/PFWJ jfX6zLa8t2m+XkRd3/m/IOjrXXmRLf0wzMuA705uRD0n4+nnlXwme9Ud3WEWMuSxz6b+ do2SqvmPiTitv0bKGkLbgs3QazwLCS7EP3dYL/F6zBrbvN3ZX86cvPgXA/uFcC4zjNxS KBnPXQgqyoXZZJM71V9hOSR0Kzt7O+HZXA/MlOY6imcE97oRO1XVH1smeZlMMbV4qELz vKrQ== X-Gm-Message-State: AOAM532PCCjUVOFteopTwd5npAtb1UX4pCda3jNilbdzvCsNfaf4GkT0 7WA2joWFjJzEvP5lpqvWMZbX+oc7Ouwss7aF12H7ZwZvBTBI/POeQuWJobp6lrVibRXUiELLSZx RBNTqYBhFHVpj0nKfoJy6 X-Received: by 2002:a0c:e28b:: with SMTP id r11mr2963881qvl.23.1600912489905; Wed, 23 Sep 2020 18:54:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwvch6+L/F9G8NP2SkabJ5Z3Wd28fOUxQYR1iEULkbxMGFKqf7E6IpFjkvP2iSwwtN/HjjYgw== X-Received: by 2002:a0c:e28b:: with SMTP id r11mr2963856qvl.23.1600912489287; Wed, 23 Sep 2020 18:54:49 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id d76sm1171722qkc.81.2020.09.23.18.54.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 23 Sep 2020 18:54:47 -0700 (PDT) Subject: Re: [PATCH] Set locale related environment variables in debugglibc.sh To: Arjun Shankar , libc-alpha@sourceware.org Cc: "Gabriel F. T. Gomes" References: <20200923160655.GA16688@aloka.lostca.se> From: Carlos O'Donell Organization: Red Hat Message-ID: Date: Wed, 23 Sep 2020 21:54:46 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200923160655.GA16688@aloka.lostca.se> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 01:54:55 -0000 On 9/23/20 12:06 PM, Arjun Shankar wrote: > From: Arjun Shankar > > Tests and binaries that use locale related functions need to run in the > correct locale environment when being debugged via debugglibc.sh. This > commit sets up the environment, specifically: GCONV_PATH, LOCPATH, and > LC_ALL for such tests and binaries when they are being debugged outside > of a test container. OK to commit. Reviewed-by: Carlos O'Donell > --- > Makefile | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/Makefile b/Makefile > index 6dcfe40c25..e047e504be 100644 > --- a/Makefile > +++ b/Makefile > @@ -305,6 +305,15 @@ then > exit 1 > fi > > +# Container tests needing locale data should install them in-container. Agreed. And any non-SUPPORTED locales can be built outside of the container and then installed by the container script. We should try hard to make the container tests look like normal installs. > +# Other tests/binaries need to use locale data from the build tree. > +if [ "$$CONTAINER" == false ] > +then > + ENVVARS="GCONV_PATH=$${BUILD_DIR}/iconvdata $$ENVVARS" OK. > + ENVVARS="LOCPATH=$${BUILD_DIR}/localedata $$ENVVARS" OK. > + ENVVARS="LC_ALL=C $$ENVVARS" OK. > +fi > + > # Expand environment setup command > if [ -v ENVVARS ] > then > -- Cheers, Carlos.