From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from crimson.ash.relay.mailchannels.net (crimson.ash.relay.mailchannels.net [23.83.222.44]) by sourceware.org (Postfix) with ESMTPS id 156463858C52 for ; Wed, 4 Oct 2023 15:05:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 156463858C52 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=sourceware.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E05429017ED; Wed, 4 Oct 2023 15:05:44 +0000 (UTC) Received: from pdx1-sub0-mail-a234.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 669389012E2; Wed, 4 Oct 2023 15:05:44 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1696431944; a=rsa-sha256; cv=none; b=hcoe0AylTP8OzuX1FpUwSj6PZYSC3mekNA04mkQBK9h9NRrd9Zu50BD/cOHK7hte8FF7s+ eoCniAD5AZGZu4G2t/bXF0tCJ5q2CiOPQZ695tWQkQ1yiEG3yMjUhE4zXtfwMKHAWPZQdV HIjOgKCPtYDf34tx0cG3Sxh+vRChjhMlnrkAKMiy1SqlgDn9O+9oNvzTNjWg62xc4nJS/2 JpFACPgtkkRs8PY+bTNA3gmP0/k8BSUDP2N11gS6DBL/J7HiQYuQ+OuTX884QqILgUo5F8 DnnaYyfH+T/2cJy1HJEEXMSq4cgKd03EU7T+Nkcnr5Aqzdy/n9+vR6aqw09jgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1696431944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iL0ZEoW+LwDR4NQ1Mdgu5NsslnS6+bvWzxM34dOMzqA=; b=VX4zTC0QfR3LF4e2A1D0QAxfDB6I1NpsqpcNskWm0IJvffoq2h8fYuhg8XU72WJRvMAG/d 331rwKK5v1sQZ2sgnKZfCTRUm3ais09kOPvdrXHyfIqqqAbHY8e3A0gbamgScogFoNad+u Y0wD+8XHjZYMZRUjN2+Bo9QVyiPS5RHeEpUcN025djSur1XrK4mtK66Y2zahaf6Ljmf6VS 2RPTEIYlQ+NGuHG+xLlmWX6ps73Lssj8Dipgh6ty6YoZa4rFSMGVBpMpRt0jl1AA0F1EWz 1m0xURBX8pZpJVXgOxgRcz7u1FsC25JxYsd+18+7CFYnjpbJ19j4hAZJBxOpMg== ARC-Authentication-Results: i=1; rspamd-7d5dc8fd68-wbd6g; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Vacuous-Chemical: 084f19163bade312_1696431944680_2926315486 X-MC-Loop-Signature: 1696431944680:4157248120 X-MC-Ingress-Time: 1696431944680 Received: from pdx1-sub0-mail-a234.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.120.41.146 (trex/6.9.1); Wed, 04 Oct 2023 15:05:44 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-02-142-113-138-41.dsl.bell.ca [142.113.138.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a234.dreamhost.com (Postfix) with ESMTPSA id 4S0ygC6KKtz4d; Wed, 4 Oct 2023 08:05:43 -0700 (PDT) Message-ID: Date: Wed, 4 Oct 2023 11:05:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] aarch64: Make glibc.mem.tagging SXID_ERASE Content-Language: en-US From: Siddhesh Poyarekar To: Szabolcs Nagy , libc-alpha@sourceware.org Cc: adhemerval.zanella@linaro.org, fweimer@redhat.com, carlos@redhat.com References: <240d1f1a-685a-2281-531f-00fd4f2cf1a6@sourceware.org> In-Reply-To: <240d1f1a-685a-2281-531f-00fd4f2cf1a6@sourceware.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1167.0 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-04 10:53, Siddhesh Poyarekar wrote: > On 2023-10-04 10:51, Szabolcs Nagy wrote: >> personally i think setuid binaries should not touch the >> env, just ignore it, so everything SXID_IGNORE. >> >> it's not just the string twiddling but tunables_strdup >> is a problem too (it can fail, needs early alloc,..). >> ideally tunables_init would be a nop with AT_SECURE and >> otherwise parsed the env var without malloc and touching >> the env[] array passed by the kernel. >> > > Sure, that could be a less contentious change.  I'll send v2 with it. I should clarify though, that I'm not removing tunables_strdup because it's still needed for regular tunables processing. The v2 I'm testing will simply make all tunables SXID_IGNORE and tunables_init a nop with AT_SECURE. Sid