From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x92b.google.com (mail-ua1-x92b.google.com [IPv6:2607:f8b0:4864:20::92b]) by sourceware.org (Postfix) with ESMTPS id 361B23858416 for ; Thu, 3 Feb 2022 20:53:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 361B23858416 Received: by mail-ua1-x92b.google.com with SMTP id b37so7422642uad.12 for ; Thu, 03 Feb 2022 12:53:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:references:in-reply-to :content-transfer-encoding; bh=RIL3V9JWmkT2S6ESXzEnDjN4l4irRQp6soBrSO8lZYk=; b=NBRfJUFTKoBPKCbU+v1WeZKumyoLajF30AZW3SieL2naDpRnwH8ra3ouFFoLwNgWXF ewvOvySajGMCejAg+NSbZXwP5Pl6CBVTrKAicSzajvB5v7km01stxtzPHbSCX0I3cT6J gAZ2R29JIpQWiRBGT4Jo2dmZh9JXwdxKla/iL+k9m6yiqrLSbLeiBdBK2WS1ag+HwkvR AJtDergtER8It5nU/mR336L0D22gyNGXTc+4iTPBVrBUiKWkjeNEuRI+g4P+VhsH4C0F bAaAINA8ERiR8elTTjD8/ZiG9xa/ncWroW20eUNANW4o9e5tAP8vRTmA8By3+ueeHAGD +a2g== X-Gm-Message-State: AOAM532G1dus46IQy8Uo/xHPUxK5yiveN1XPLWQsxD4byhWGzqcMKRV+ bFeKiBE+uAicqFFmfrN4gobjJ12ku75Ruw== X-Google-Smtp-Source: ABdhPJy5rJD2YQLN9NyQW9m/IuPS++KB3n3Fei1KDtpafZEMSVrb49uM2sSKmBHyjLPYIeprWgvMDg== X-Received: by 2002:a67:d796:: with SMTP id q22mr13972003vsj.42.1643921579586; Thu, 03 Feb 2022 12:52:59 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:22aa:9542:591f:6eb9? ([2804:431:c7ca:709a:22aa:9542:591f:6eb9]) by smtp.gmail.com with ESMTPSA id r4sm422874vsk.2.2022.02.03.12.52.58 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Feb 2022 12:52:58 -0800 (PST) Message-ID: Date: Thu, 3 Feb 2022 17:52:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v2 2/3] inet: Remove strdupa from nrl_domainname() Content-Language: en-US From: Adhemerval Zanella To: libc-alpha@sourceware.org References: <20211210110733.1499984-1-adhemerval.zanella@linaro.org> <20211210110733.1499984-3-adhemerval.zanella@linaro.org> In-Reply-To: <20211210110733.1499984-3-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Feb 2022 20:53:01 -0000 Ping. On 10/12/2021 08:07, Adhemerval Zanella wrote: > We can use the already in place scratch_buffer. > > Checked on x86_64-linux-gnu. > --- > inet/getnameinfo.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/inet/getnameinfo.c b/inet/getnameinfo.c > index 5eee354200..2d2397e7dc 100644 > --- a/inet/getnameinfo.c > +++ b/inet/getnameinfo.c > @@ -118,15 +118,15 @@ nrl_domainname_core (struct scratch_buffer *tmpbuf) > else > { > /* We need to preserve the hostname. */ > - const char *hstname = strdupa (tmpbuf->data); > - while (__gethostbyname_r (hstname, &th, > - tmpbuf->data, > - tmpbuf->length, > + size_t hstnamelen = strlen (tmpbuf->data) + 1; > + while (__gethostbyname_r (tmpbuf->data, &th, > + tmpbuf->data + hstnamelen, > + tmpbuf->length - hstnamelen, > &h, &herror)) > { > if (herror == NETDB_INTERNAL && errno == ERANGE) > { > - if (!scratch_buffer_grow (tmpbuf)) > + if (!scratch_buffer_grow_preserve (tmpbuf)) > return; > } > else