From: Stefan Liebler <stli@linux.ibm.com>
To: Florian Weimer <fweimer@redhat.com>,
Stefan Liebler via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] S390: Add new s390 platform z16.
Date: Thu, 14 Apr 2022 10:39:42 +0200 [thread overview]
Message-ID: <c85ac77d-95e1-20b3-8f02-ee2d2fc53a92@linux.ibm.com> (raw)
In-Reply-To: <87zgkp2ebo.fsf@oldenburg.str.redhat.com>
On 13/04/2022 17:27, Florian Weimer wrote:
> * Stefan Liebler via Libc-alpha:
>
>> @@ -63,9 +64,11 @@ compute_level (void)
>> return 12;
>> if (strcmp (platform, "z15") == 0)
>> return 13;
>> + if (strcmp (platform, "z16") == 0)
>> + return 14;
>> printf ("warning: unrecognized AT_PLATFORM value: %s\n", platform);
>> /* Assume that the new platform supports z15. */
>> - return 13;
>> + return 14;
>
> z15 in the comment needs updating. Rest looks okay to me.
>
> Thanks,
> Florian
>
Thanks for this catch. Committed with the updated comment.
Thanks,
Stefan
prev parent reply other threads:[~2022-04-14 8:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:36 Stefan Liebler
2022-04-13 15:27 ` Florian Weimer
2022-04-14 8:39 ` Stefan Liebler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85ac77d-95e1-20b3-8f02-ee2d2fc53a92@linux.ibm.com \
--to=stli@linux.ibm.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).