From: Peter Bergner <bergner@linux.ibm.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Cc: Paul E Murphy <murphyp@linux.ibm.com>
Subject: Re: [PATCH v2] powerpc: Fix __fesetround_inline_nocheck on POWER9+ (BZ 31682)
Date: Mon, 6 May 2024 13:46:59 -0500 [thread overview]
Message-ID: <c9b556b6-fbbf-40d3-a213-7d6d8aa77a85@linux.ibm.com> (raw)
In-Reply-To: <20240506170807.1644139-1-adhemerval.zanella@linaro.org>
On 5/6/24 12:07 PM, Adhemerval Zanella wrote:
> floating-point inexact exception enablebbit, however mffscrni
Is that supposed to be "enable bit" or "enabled bit"?
> +/* Same as __fesetround_inline, but it also disable the floating-point
> + exceptions (bits 56:63 - VE, OE, UE, ZE, XE, NI, and RN). It does
> + not check if ROUND is a valid value. */
s/disable/disables/
The rest LGTM.
Reviewed-by: Peter Bergner <bergner@linux.ibm.com>
I'd like to hear Paul's comments though.
Peter
next prev parent reply other threads:[~2024-05-06 18:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 17:07 Adhemerval Zanella
2024-05-06 18:46 ` Peter Bergner [this message]
2024-05-06 20:07 ` Paul E Murphy
2024-05-07 12:02 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9b556b6-fbbf-40d3-a213-7d6d8aa77a85@linux.ibm.com \
--to=bergner@linux.ibm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=murphyp@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).