From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by sourceware.org (Postfix) with ESMTPS id 70A7D3938C27 for ; Mon, 11 May 2020 20:13:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 70A7D3938C27 Received: by mail-qv1-xf42.google.com with SMTP id g20so2230818qvb.9 for ; Mon, 11 May 2020 13:13:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=ZgouXrQY3FeG0m+WufFThAw1J7Nvg9ZI2j1grRQWfQ8=; b=jpQPrUXm1JeYiBMa+Qtzo/sJIK7xz977TMxgV8PaXKzxgLNpD1icCutCp6S/6Y4kgK R7THk1aVHWl6JD0ta0g9OPDX6eTFmolEZv9JcOvwoSkuXcBqmvSLJeF2yLGyO6KcinFF MgpqKlb13i+YyCB2YL7sMw0KZFW3TTLHCbZbQJqOkR4e5wAd9Pqva5ThQ5tc/s4Kno7m CA398t8m2VVbPj+zk9ZHQg2oVmk3FomfK4OGDXJV7RI3PFKlpkEv9OhJItY2HgICBYKa I072OTdrqi2+xs0q1jswXMzkQIQzi5NOPdpMSO5Z5l5PNns0FhFbPkHkg1c4c8xp6IKA YH+A== X-Gm-Message-State: AGi0PualHEtxFxccctT0ZwHEA8rRqoHX8u0KwgNgotAbrvqg0bqqqBAf 0gGmnSZ5ygoKSeMWZ0PwOynQbuSsGGg= X-Google-Smtp-Source: APiQypJUs6Y791Pt5irkG4tv1XPJ7DCo1uCelczlVhE2dFDItVQa+WTob76q3d/xNT87q5huCjDgNA== X-Received: by 2002:a0c:f791:: with SMTP id s17mr17383894qvn.36.1589228027063; Mon, 11 May 2020 13:13:47 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id i23sm9230387qke.65.2020.05.11.13.13.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2020 13:13:46 -0700 (PDT) Subject: Re: [PATCH 11/12] aarch64: redefine RETURN_ADDRESS to strip PAC To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20200430173458.GV29015@arm.com> <20200430174518.GG29015@arm.com> <60967e5e-f6fb-c556-d7fb-ec3c737ed2fd@linaro.org> <20200511123850.GI7649@arm.com> <2cb466d5-fae2-d746-45ce-eab06e30562e@linaro.org> <8736865lbm.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= mQINBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABtElBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+iQI3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AquQINBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABiQIfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: Date: Mon, 11 May 2020 17:13:43 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <8736865lbm.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 May 2020 20:13:49 -0000 On 11/05/2020 16:21, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> On 11/05/2020 09:38, Szabolcs Nagy wrote: >>> The 05/08/2020 14:44, Adhemerval Zanella via Libc-alpha wrote: >>>> On 30/04/2020 14:45, Szabolcs Nagy wrote: >>>>> +++ b/sysdeps/aarch64/sysdep.h >>>>> @@ -35,6 +35,16 @@ >>>>> >>>>> #define PTR_SIZE (1<>>>> >>>>> +/* Strip pointer authentication code from pointer p. */ >>>>> +#define XPAC(p) ({ \ >>>>> + register void *__ra asm ("x30") = (p); \ >>>>> + asm ("hint 7 // xpaclri" : "+r"(__ra)); \ >>>>> + __ra;}) >>>>> + >>>>> +/* This is needed when glibc is built with -mbranch-protection=pac-ret. */ >>>>> +#undef RETURN_ADDRESS >>>>> +#define RETURN_ADDRESS(n) XPAC(__builtin_return_address(n)) >>>>> + >>>> >>>> Maybe use a inline function instead? >>> >>> macro seems more reliable to me than always_inline >>> when poking at __builtin_return_address and x30, >>> but i'm not against always_inline if that's >>> considered better. >> >> I would prefer a static inline unless a macro is really required >> (either due some compiler limitation or bug). > > I think __builtin_return_address is ill-defined: Does the frame count > that vanishes due to inlining? > > So it's probably a case similar to alloca, where a macro has to be > used. This is at least what documentation states [1]: "When inlining the expected behavior is that the function returns the address of the function that is returned to. To work around this behavior use the noinline function attribute." [1] https://gcc.gnu.org/onlinedocs/gcc/Return-Address.html