From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7134 invoked by alias); 27 Sep 2019 14:27:18 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 7126 invoked by uid 89); 27 Sep 2019 14:27:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-10.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.1 spammy=convey, threw X-HELO: mx0a-001b2d01.pphosted.com Subject: Re: [PATCH v2 4/6] [powerpc] libc_feholdsetround_noex_ppc_ctx: optimize FPSCR write To: Paul Clarke , libc-alpha@sourceware.org Cc: tuliom@ascii.art.br References: <1568918810-20393-1-git-send-email-pc@us.ibm.com> <1568918810-20393-5-git-send-email-pc@us.ibm.com> <943be10e-497d-1066-42cf-12164c71ed28@linux.ibm.com> <5651ac5e-8b7e-3596-b7c9-617cae7dea3f@us.ibm.com> From: Paul E Murphy Message-ID: Date: Fri, 27 Sep 2019 14:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <5651ac5e-8b7e-3596-b7c9-617cae7dea3f@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-09/txt/msg00479.txt.bz2 On 9/23/19 12:54 PM, Paul Clarke wrote: > Thanks for the review, Paul! Question... > > On 9/23/19 10:54 AM, Paul E Murphy wrote: >> On 9/19/19 1:46 PM, Paul A. Clarke wrote: >>> libc_feholdsetround_noex_ppc_ctx currently does, basically: >> The listing reads awkwardly for me. I suggest a little cleanup. There is no need to post a new patch against my suggestion. > > Here you say "listing", and there is a list (1-2-3) immediately below this text, and below you say "commit message", . Where would you like to see improvement? Happy to change, but it's hard for me to see what you're seeing. (And, of course, it's all perfectly clear to me since I wrote it! ;-) > >>> 1. Read FPSCR, save to context. >>> 2. Create new FPSCR value: clear enables and set new rounding mode. >>> 3. Write new value to FPSCR. >>> I think the change of tense and verb leading into the list threw me off. Feel free to commit with or without changes as the message does convey the intent of the patch.