From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-78836-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 85478 invoked by alias); 21 Apr 2017 14:24:35 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 85218 invoked by uid 89); 21 Apr 2017 14:24:21 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=
X-HELO: mx1.redhat.com
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 1476C235379
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=fweimer@redhat.com
DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 1476C235379
Subject: Re: [PATCH v3][BZ 21340] add support for POSIX_SPAWN_SETSID
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
 libc-alpha@sourceware.org
Cc: Zack Weinberg <zackw@panix.com>
References: <20170405054116.9007-1-quae@daurnimator.com>
 <ce204caa-739f-307b-bc44-f3d17f27e55e@redhat.com>
 <CAEnbY+dyj535NeaOz6EbVU6od3JKV+61PTWx7EXbXeZHCa5G6g@mail.gmail.com>
 <75eb12d0-a3f1-2b37-90d5-0a9a3f7f9a99@redhat.com>
 <CAEnbY+c3X_xHaWyWQX+fOX_h1jrac+RFBzu+TN3wfYv2Ay7azA@mail.gmail.com>
 <CAEnbY+c4LvwouziVuZxRym0wX7FE=h0EVUFNo4_pDx2-9GuHJQ@mail.gmail.com>
 <a76bbb82-02c8-95fc-d49f-7f474f9179c2@linaro.org>
From: Florian Weimer <fweimer@redhat.com>
Message-ID: <c9d4e975-da57-5651-75d5-41e81857a8ca@redhat.com>
Date: Fri, 21 Apr 2017 14:24:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.0
MIME-Version: 1.0
In-Reply-To: <a76bbb82-02c8-95fc-d49f-7f474f9179c2@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-04/txt/msg00462.txt.bz2

On 04/21/2017 04:13 PM, Adhemerval Zanella wrote:

> 	* conform/data/spawn.h-data: Add POSIX_SPAWN_SETSID flag.

I think this has to go away ...


> diff --git a/posix/spawn.h b/posix/spawn.h
> index 36e3867..8d2ace1 100644
> --- a/posix/spawn.h
> +++ b/posix/spawn.h
> @@ -60,6 +60,7 @@ typedef struct
>   #ifdef __USE_GNU
>   # define POSIX_SPAWN_USEVFORK		0x40
>   #endif
> +#define POSIX_SPAWN_SETSID		0x80


... because this has to be governed by __GNU_SOURCE.

> +static int
> +do_test (void)
> +{
> +  pid_t sid, child_sid;
> +  int res;
> +
> +  /* Current session ID.  */
> +  sid = getsid(0);
> +  if (sid == (pid_t) -1)
> +    FAIL_EXIT1 ("getsid (0): %m");
> +
> +  posix_spawnattr_t attrp;
> +  posix_spawnattr_init (&attrp);
> +  if (posix_spawnattr_setflags (&attrp, POSIX_SPAWN_SETSID))
> +    FAIL_EXIT1 ("posix_spawnattr_setflags: %m");

Please run the test twice, once with setting POSIX_SPAWN_SETSID, and 
once without.

Thanks,
Florian