From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bird.elm.relay.mailchannels.net (bird.elm.relay.mailchannels.net [23.83.212.17]) by sourceware.org (Postfix) with ESMTPS id B7D1E3858D1E for ; Tue, 18 Apr 2023 12:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7D1E3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5C9871014F4; Tue, 18 Apr 2023 12:54:48 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BC3A510163A; Tue, 18 Apr 2023 12:54:47 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1681822487; a=rsa-sha256; cv=none; b=yiF8vxGtmboMh6sysa//mbR8QsUMTLP1Cezk1a/mB2usTqj65U7Sumxmi5rnarmQeDfXVB zkNxZJVbID8hSaCE4L7QN7PGgglpNEeZELX6dgefY2p8BXlP6uKa8mfURlOQgINEmbFxka qJq0RcjMdvVklC/FI3e9EiyhNtBi5/IsN7H6hKqAa+sqLtIFg7oqi3AHzO2DQihpkiEbpd DNtKalf5rI9+1LxgF+JDSrMLILxh4OsP/5Q2FJ/x1tnxLi1syvVNeFejfjHvwVx0V6hbui SGs6KPQ9zTsrAVxs9ZW4Ul2p2JH7XLLIrEe9/8e6LGaqsP2b4qyDu5HMA3Jjmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1681822487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=18Ltw7pSTCkpPpLUCDwJ5GXFHTXeIxM4CG5bnCUywiQ=; b=2j1Oye59rj6p0OS6iVvwT/VHxk6RIa58Jg498HfD10h129u6IQh9iJKK++Hcp92cuhzjr9 C2/qCkAN5SdNGOpwE5kk3/W/flk6BsTK4dUkz6+A8FIsbF7pDWgAbA5Bfl3dF628s5HG4B JLoo75plxpY2JAPmHWoFWDYL1wetVI3b0ccJzpnGAYfyEo5OlsXtQyxEDVOnsIyhWv2P7W PI706He3Y6IMLF+xCLSTNrv86dS0WfN5Am1sAnFOrlnh6NeJmodTWQ3f28AuTy2Ho8woFF WnEjk8H2QC6b34ZE9VVrlLWEv+ZOk+/RDmKTMV1Bn8zb1+fHe1+TPQZ1QHeX1Q== ARC-Authentication-Results: i=1; rspamd-7f66b7b68c-qtktf; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wide-Eyed-Zesty: 544f3ba025634bcb_1681822488038_890766279 X-MC-Loop-Signature: 1681822488038:307084693 X-MC-Ingress-Time: 1681822488038 Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.59.39 (trex/6.7.2); Tue, 18 Apr 2023 12:54:48 +0000 Received: from [192.168.2.12] (bras-vprn-toroon4834w-lp130-09-174-91-45-80.dsl.bell.ca [174.91.45.80]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4Q13m71lgWzLs; Tue, 18 Apr 2023 05:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1681822487; bh=18Ltw7pSTCkpPpLUCDwJ5GXFHTXeIxM4CG5bnCUywiQ=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=koHl45WC0WP1Awmx+bHFmtTn1Nmq+2tSABcUKyWqO2fLez1TpUTIOQ8bbm4Gv/klE sqDjY4kBkz9HF8mZ7FTLOcBj273UYawU8b/VgPM3NV3M3wb1SeySkz5km63bolUONC NuaJCK6keKlEz5w1I9qHKfoiaY6foH/Y2ogxPktx9QzJyo2J3QHrTsYtu7IJCmaq6A v3RxBB13Y1uijbnAM1KcqhnMEhGcKved3WEVw8uLfwMc4efSV98CUtaKlWDY+jAW2J QxzxUOCle4hCb5CyDM7c5m1nUMiaLPbDdH7snN8DOVQkw8pgaGHv5dR71UUkDr3o9E kscKKcp5ipQZQ== Message-ID: Date: Tue, 18 Apr 2023 08:54:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 8/8] sysdeps/pthread/eintr.c: fix warn unused result Content-Language: en-US To: =?UTF-8?B?RnLDqWTDqXJpYyBCw6lyYXQ=?= , libc-alpha@sourceware.org Cc: sipoyare@redhat.com References: <20230418121130.844302-1-fberat@redhat.com> <20230418121130.844302-9-fberat@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230418121130.844302-9-fberat@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3039.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-04-18 08:11, Frédéric Bérat via Libc-alpha wrote: > Fix unused result warnings, detected when _FORTIFY_SOURCE is enabled in > glibc. > --- > sysdeps/pthread/eintr.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sysdeps/pthread/eintr.c b/sysdeps/pthread/eintr.c > index 000649d24e..8441df0c77 100644 > --- a/sysdeps/pthread/eintr.c > +++ b/sysdeps/pthread/eintr.c > @@ -31,10 +31,10 @@ eintr_handler (int sig) > { > if (sig != the_sig) > { > - write (STDOUT_FILENO, "eintr_handler: signal number wrong\n", 35); > + if (write (STDOUT_FILENO, "eintr_handler: signal number wrong\n", 35)) {}; Perhaps add a little comment here saying that it avoids the __wur? Also, make the check < 35 so that it's semantically correct. > _exit (1); > } > - write (STDOUT_FILENO, ".", 1); > + if (write (STDOUT_FILENO, ".", 1)) {}; > } Likewise. > > Thanks, Sid