From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) by sourceware.org (Postfix) with ESMTPS id 697B0385AC30 for ; Wed, 2 Nov 2022 17:18:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 697B0385AC30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-13c569e5ff5so20632206fac.6 for ; Wed, 02 Nov 2022 10:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eIlb8oSgUDSeNQmAihwQCZ9rld2VVqrPvy1c63zg4AE=; b=U64XZ6ndXT+9y/Di3iayz7iP1udzo3i930iHvXSijByCzFGo2ioUemWYSDwqeZiiV2 sZL1ykEhtvB2vAQPsDnOufudeFLFg3thMZDl0pv4mZ60Pbl68I+Oyn2+jgkt0VJH0uYh MnuX8FKPqQE6UgyrbfXy8ujL3pEZdWWqno9M2UistUHbrOiPfiDYZw/IoApULMc7U4AZ PpEjpco8wBlhkpi6xY+Fpid2UJxiLl2kVWeyQVPmk1uUMgERky/+syeCyk6jtfBW28Sz OykT3pVSy+P7q0V77layoYnsTmFsreF9R1ZJVlsboH55gjQ1HcZxOnPXGNPUw/f+f5Lb 5rgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eIlb8oSgUDSeNQmAihwQCZ9rld2VVqrPvy1c63zg4AE=; b=S3c42YQt4YBBdy3YgZ+7ruZww3f21ESSHqC3nooBc7TJLB05wTL56M+vCnfRn7kCLW Gw/Av15t5P4V62hlhf/+Ku49Tt3UKOkxGJFQ1g85LG+SS6k+WBpncPdAs4Swjj9hVasR /CR244G0tZ6vKE0hGixMDGK6nwjOx0FIKcCNjhvYpb6XZ+ZE+ev3IFXygAA84rrNufx5 mzroSJLVBVmH63j4TwsRLS40O22HtIhqjXl1JhOJ09wGfrSzSZ5p+NaWUngV2Yy7CpNd mlQEDkbVCtHwmxhUCOsxv3Ge7XKi7PI7/stbZYYCPZ81UXJ2/qc2X2myH51AgDGBMs+Y 3+gw== X-Gm-Message-State: ACrzQf0SgY8y+zggKJhabIMddlYoNIxwnyro2LTJ/USBF1RclVCpZGz0 cgT2A7OTKxB7tpoTZ4uiIDXiVs3aNkXe3tNW X-Google-Smtp-Source: AMsMyM7UZBX8h9EblBCRT65wy+GOxN/Z7ynPt+jBwOznmMd+6nE4WICnNFIrA5ikl7sJryPGTme5TA== X-Received: by 2002:a05:6870:e253:b0:13c:765e:90b0 with SMTP id d19-20020a056870e25300b0013c765e90b0mr18536727oac.50.1667409525680; Wed, 02 Nov 2022 10:18:45 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c0:a9f4:4093:e060:2c0e:46f6? ([2804:1b3:a7c0:a9f4:4093:e060:2c0e:46f6]) by smtp.gmail.com with ESMTPSA id w25-20020a9d6399000000b0066c39c99ae5sm5252144otk.25.2022.11.02.10.18.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Nov 2022 10:18:45 -0700 (PDT) Message-ID: Date: Wed, 2 Nov 2022 14:18:43 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2] linux: Drop useless include from fstatat.c Content-Language: en-US To: Aurelien Jarno , libc-alpha@sourceware.org References: <20221101213608.22458-1-aurelien@aurel32.net> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20221101213608.22458-1-aurelien@aurel32.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 01/11/22 18:36, Aurelien Jarno wrote: > It is a left-over from previous refactorings. LGTM, thanks. Reviewed by: Adhemerval Zanella > --- > sysdeps/unix/sysv/linux/fstatat.c | 2 -- > 1 file changed, 2 deletions(-) > > Sorry, I failed to properly test v1, we need to include > to get XSTAT_IS_XSTAT64 (which is not the case on the MIPSn64 patch). > > diff --git a/sysdeps/unix/sysv/linux/fstatat.c b/sysdeps/unix/sysv/linux/fstatat.c > index 055fb4762e..8926eed244 100644 > --- a/sysdeps/unix/sysv/linux/fstatat.c > +++ b/sysdeps/unix/sysv/linux/fstatat.c > @@ -21,8 +21,6 @@ > #include > > #if !XSTAT_IS_XSTAT64 > -# include > - > int > __fstatat (int fd, const char *file, struct stat *buf, int flag) > {