From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7610D3858C83 for ; Wed, 11 Jan 2023 21:43:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7610D3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673473410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOX15cIlfwgD0R8GATUUJHDlpnfNZGTFp4nAoFsnjs4=; b=E7hch9g01FNJUmzNHfOSz4YvuiDu2W1BwcnNvQSgOdRzGeBWxg2eKoAV8l7n2QjEN5JyEt 7q+pP+jtJ2UZkf/QbNv9+Ks1KbbStnrHlu/yq99C1GPReYG3kJjr50E5IZxCfeZu5JGyKr xEnMyfxBnABQTzLEg/46rxBnjtNhkbo= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-656-zDY4KJpZOFy2tDEDwLoTsQ-1; Wed, 11 Jan 2023 16:43:29 -0500 X-MC-Unique: zDY4KJpZOFy2tDEDwLoTsQ-1 Received: by mail-il1-f199.google.com with SMTP id y11-20020a056e02178b00b0030c048d64a7so11876654ilu.1 for ; Wed, 11 Jan 2023 13:43:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DOX15cIlfwgD0R8GATUUJHDlpnfNZGTFp4nAoFsnjs4=; b=jat5Sjq98UIi0d8WGm89TiNSI5Mwg9v3r7Fc/IsTs6FZw7TrFPwTMVDrG6RH6fd7TF QXiSONXVjfJfjROk1Uz8IABJK/4cuA+mPKOdJtLpLDAZIjm4ORvoQX9xH9sydbZWX6W2 oy5NpFXIOhb16hO7zIySYdSrNk6oOKXZpy2a18Jux1Bn5S7l1DxRKe7EJ9wKaoIm8pSf GvGBS4f2vcrGMUtD+Fdj81fik80uowplS8StdZQ+BixP3VmngknkSA0y7krZ1zyxxsZu XANy24R3bf+uLy2CPt6gvWRIcPjdS6mX2s+ly9dZ106vl2bF0mMXkAzx4cq6CgkpTlne BMyA== X-Gm-Message-State: AFqh2koF6Z5jWyPAgbvT6T46xstYSLL+ffFVHDLvMnsApVGF3zBcL9xG PSblHhGzZQlZDzm0hvNCSfq+Fksjb728tV0D/Ikyf39FRvMYdcfIYoeeBCbcXrJaDoEcWb6D/AG vXuK8eikOttOEgRZCXEOR X-Received: by 2002:a92:c14f:0:b0:30d:c130:6cb9 with SMTP id b15-20020a92c14f000000b0030dc1306cb9mr3043441ilh.28.1673473408327; Wed, 11 Jan 2023 13:43:28 -0800 (PST) X-Google-Smtp-Source: AMrXdXvWkptp0JQ5ubY0uWhdY8oXvPBu6/X0AOzK8jG5dInnAL8la/ePKa78vm+vW+dumNuZihvmzQ== X-Received: by 2002:a92:c14f:0:b0:30d:c130:6cb9 with SMTP id b15-20020a92c14f000000b0030dc1306cb9mr3043422ilh.28.1673473407950; Wed, 11 Jan 2023 13:43:27 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id n30-20020a02a19e000000b0039de238deb5sm4802377jah.175.2023.01.11.13.43.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jan 2023 13:43:27 -0800 (PST) Message-ID: Date: Wed, 11 Jan 2023 16:43:26 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v2 03/11] Linux: Do not align the stack for __clone3 To: Adhemerval Zanella , libc-alpha@sourceware.org, Szabolcs Nagy , "H . J . Lu" Cc: Christian Brauner References: <20221104190112.2566409-1-adhemerval.zanella@linaro.org> <20221104190112.2566409-4-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221104190112.2566409-4-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/4/22 15:01, Adhemerval Zanella via Libc-alpha wrote: > Adjusting the stack on child thread is not async-signal safe, since > kernel does not enforce stack alignmnet. Although, all the internal > usage of __clone_internal are done with all signal masked, removing > stack alignment of __clone3 is still a net gain: is simplifies the > function contract detail (mask/unmarsk signals) and simplifies the > arch-specific code. Please post v4. Suggest: All internal callers of __clone3 should provide an already aligned stack. Removing the stack alignment in __clone3 is a net gain: it simplifies the internal function contract (mask/unmask signals) along with the arch-specific code. > > The internal users are responsible for correct stack alignment. If > glibc ever exports a clone3 wrapper, it should adjust stack alignment. > > Checked on x86_64-linux-gnu. > --- > include/clone_internal.h | 5 ++ > .../sysv/linux/tst-misalign-clone-internal.c | 74 ------------------- > sysdeps/unix/sysv/linux/x86_64/clone3.S | 3 - > 3 files changed, 5 insertions(+), 77 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c > > diff --git a/include/clone_internal.h b/include/clone_internal.h > index 73b8114df4..5a48c7caa5 100644 > --- a/include/clone_internal.h > +++ b/include/clone_internal.h > @@ -11,6 +11,11 @@ > Different than kernel, the implementation also returns EINVAL for an > invalid NULL __CL_ARGS or __FUNC (similar to __clone). > > + The stack is not aligned prior the syscall, different than exported > + __clone. Adjusting the stack on child is not async-signal safe and since > + it is used only internally the caller is responsible for proper stack > + alignment. Suggest: All callers are responsible for correctly aligning the stack. The stack is not aligned prior to the syscall (this differs from the exported __clone). > + > This function is only implemented if the ABI defines HAVE_CLONE3_WRAPPER. > */ > extern int __clone3 (struct clone_args *__cl_args, size_t __size, > diff --git a/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c b/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c > deleted file mode 100644 > index e039ca5a3a..0000000000 > --- a/sysdeps/unix/sysv/linux/tst-misalign-clone-internal.c > +++ /dev/null > @@ -1,74 +0,0 @@ > -/* Verify that __clone_internal properly aligns the child stack. > - Copyright (C) 2021-2022 Free Software Foundation, Inc. > - This file is part of the GNU C Library. > - > - The GNU C Library is free software; you can redistribute it and/or > - modify it under the terms of the GNU Lesser General Public > - License as published by the Free Software Foundation; either > - version 2.1 of the License, or (at your option) any later version. > - > - The GNU C Library is distributed in the hope that it will be useful, > - but WITHOUT ANY WARRANTY; without even the implied warranty of > - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > - Lesser General Public License for more details. > - > - You should have received a copy of the GNU Lesser General Public > - License along with the GNU C Library; if not, see > - . */ > - > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > -#include > - > -static int > -check_stack_alignment (void *arg) > -{ > - puts ("in f"); > - > - return TEST_STACK_ALIGN () ? 1 : 0; > -} > - > -static int > -do_test (void) > -{ > - puts ("in do_test"); > - > - if (TEST_STACK_ALIGN ()) > - FAIL_EXIT1 ("stack isn't aligned\n"); > - > -#ifdef __ia64__ > -# define STACK_SIZE (256 * 1024) > -#else > -# define STACK_SIZE (128 * 1024) > -#endif > - char st[STACK_SIZE + 1]; > - /* NB: Align child stack to 1 byte. */ > - char *stack = PTR_ALIGN_UP (&st[0], 2) + 1; > - struct clone_args clone_args = > - { > - .stack = (uintptr_t) stack, > - .stack_size = STACK_SIZE, > - }; > - pid_t p = __clone_internal (&clone_args, check_stack_alignment, 0); > - > - /* Clone must not fail. */ > - TEST_VERIFY_EXIT (p != -1); > - > - int e; > - xwaitpid (p, &e, __WCLONE); > - TEST_VERIFY (WIFEXITED (e)); > - TEST_COMPARE (WEXITSTATUS (e), 0); > - > - return 0; > -} > - > -#include OK. > diff --git a/sysdeps/unix/sysv/linux/x86_64/clone3.S b/sysdeps/unix/sysv/linux/x86_64/clone3.S > index 18fc2ee966..989b62bdf6 100644 > --- a/sysdeps/unix/sysv/linux/x86_64/clone3.S > +++ b/sysdeps/unix/sysv/linux/x86_64/clone3.S > @@ -73,9 +73,6 @@ L(thread_start): > the outermost frame obviously. */ > xorl %ebp, %ebp > > - /* Align stack to 16 bytes per the x86-64 psABI. */ > - and $-16, %RSP_LP OK. > - > /* Set up arguments for the function call. */ > mov %R8_LP, %RDI_LP /* Argument. */ > call *%rdx /* Call function. */ -- Cheers, Carlos.