From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 4E48E385142A for ; Wed, 8 Mar 2023 13:08:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E48E385142A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1767a208b30so16687540fac.2 for ; Wed, 08 Mar 2023 05:08:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678280914; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ISjec9rO/ZQGCgLEaUA7AaryvCfq6/ILIczpPazFzdo=; b=hhW5+8kqOup+F2VKPFJJT1Z+H7+IAnZTToUQ6k99AHTVzUZdQ54XsxzM5ceNTB0yEO YCzhhZkwAOxTk2eHDGmt7e/vGNcldb+LpfkN4pIGaQSrDNohXUuEy0ukyPIb8SAhnjfA u28o8sFGN0MIIzpbiwb7RFSUErzPSHGdgrraul4QIpJTPc5uifXfnqGu3is/ubnS2XPw k/pkSP9d+BtWl3hAssgdrGinC3dWpTzB2e6e3ZWtPsMYKzcCUMnFWjpobro6//YPfBE9 WBESObGKneGuCwmOLPWczan5cQDM9vXocGc5/IxSI7DgpV9l3lYEOrPqwU/EJhZNx7s8 KC5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678280914; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ISjec9rO/ZQGCgLEaUA7AaryvCfq6/ILIczpPazFzdo=; b=0o8xnqZq97i4+iW4G8dRP6xHe5sS/zaG7ad2j2QGnU1peflyI6MTp/5eyMscosQRRH Z+c4QDgNywHIwi7zZ5wmr00fbCr4qZulCK42d+nqo5v71VC7/aBouH6u/0tAyE10bZmi gvCfFIFapfAP/K/R/vYHEZxQHq9CIUWtUYfFSQ9RxWVjIsz9kMV5lUJXUdBGZgngl+V3 ztFwVIxt92DDnZaauzSW0VOw8QLNEujHypqYjXVnhr4fhs/HwtHU4ItpsN1O9D9M3zYL A+IcbMZi2V3v/381Na8hEm5+MySbhoaiH2HLn7cRiHsuEwJOdCzbXJKShwy5n/7qhufI Z3qw== X-Gm-Message-State: AO0yUKX8oU27/7TPcmtVzWpRSI8QrMD2zIKq2rir+TZ5IUxacB1pp13p YueFxVpcC3MNhBhtjfLKJw8DbcbFGN9acdy1bnEvRg== X-Google-Smtp-Source: AK7set9klTgURTn50LiUXWo2g/WsS2w2Rl8ozOhzqnuoxyjMsxIhah7Z6qJ9CeNxZgAiUlAZjB+yQw== X-Received: by 2002:a05:6870:b50b:b0:16d:eb60:a94 with SMTP id v11-20020a056870b50b00b0016deb600a94mr10961144oap.1.1678280914535; Wed, 08 Mar 2023 05:08:34 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c0:544b:655d:5559:758d:90f7? ([2804:1b3:a7c0:544b:655d:5559:758d:90f7]) by smtp.gmail.com with ESMTPSA id f5-20020a056870d30500b001724742cfcesm6102287oag.38.2023.03.08.05.08.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Mar 2023 05:08:33 -0800 (PST) Message-ID: Date: Wed, 8 Mar 2023 10:08:30 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] posix: Ensure the initial signal disposition for tst-spawn7 Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha Cc: "H.J. Lu" References: <20230307163152.2509362-1-adhemerval.zanella@linaro.org> <87v8jbshlk.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87v8jbshlk.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 08/03/23 06:44, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> To avoid possible failure if any parent set any initial signal >> disposition as SIG_IGN. >> >> Checked on x86_64-linux-gnu. >> --- >> posix/tst-spawn7.c | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/posix/tst-spawn7.c b/posix/tst-spawn7.c >> index fedb09fb94..fb06915cb7 100644 >> --- a/posix/tst-spawn7.c >> +++ b/posix/tst-spawn7.c >> @@ -99,6 +99,12 @@ dummy_sa_handler (int signal) >> static void >> do_test_signals (void) >> { >> + /* Ensure the initial signal disposition, ignore EINVAL for internal >> + signal such as SIGCANCEL. */ >> + for (int sig = 1; sig < _NSIG; ++sig) >> + sigaction (sig, &(struct sigaction) { .sa_handler = SIG_DFL, >> + .sa_flags = 0 }, NULL); >> + >> { >> /* Check if all signals handler are set to SIG_DFL on spawned process. */ >> spawn_signal_test ("SIG_DFL", NULL); > > Finally found out what's causing my failure: running the test suite with > “nohup”. Maybe you could mention this in the comment? Anyway, the > patch is fixing things. I will add the nohup note, thanks. > > I suspect H.J. is doing the same. 8-) > > Tested-by: Florian Weimer > Reviewed-by: Florian Weimer > > Thanks, > Florian >