From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id F2BA93858C83 for ; Mon, 25 Apr 2022 17:21:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2BA93858C83 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-deb9295679so16775011fac.6 for ; Mon, 25 Apr 2022 10:21:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=GugVjC6SxaRm2pHUA4br5aAAzhX5VjLpgw1ubmbhNSg=; b=JxTXAVxRLSP2S2oxsn7phvRbT4zMTI3sr3hBJz6kvEni/sPFpvDPCgV2J3RGm5WUaN /5WfJJKxyKUu99S0sClYQgkOKIPMWhaL4ej5z6K0n8GVQ66PU4aMb76IdGSOe03i3HL9 W9Ytr3gzmbGSimp2Luk93Ug11btbka3L8kpVTJA26DpHj55HFbVTIzp/gVJjn0w6c3sl 8ZOj4kBWwONYFP2GnH08sXSLUgOyDzq660qfXWfBHegWmeJ5/HOAJ1NRobvzyQ18ZACL f84q4WoWJdRAuNOm8LSUbJi12UWkqSWzmVpWLnQUxWriz1/pFy8Wr9yeH3bK6NVDogBV imEw== X-Gm-Message-State: AOAM530U63eV9HayeX6MpN2hDXoVOg6LejWUygzQwZFGcnJmJP55YiGi XcLOS3WDk6D5YbdM2IhLcd7qjvn79ECBlQ== X-Google-Smtp-Source: ABdhPJxKvBwM0GkkEmftsvU/1L90BmEZgeHc467LKR/UhJbjcnPtXdZGswYIIPahyfHov3f60/T9qg== X-Received: by 2002:a05:6870:232a:b0:db:360c:7f5a with SMTP id w42-20020a056870232a00b000db360c7f5amr11277128oao.230.1650907273766; Mon, 25 Apr 2022 10:21:13 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:4214:b4dd:3339:98d6:1ec0? ([2804:431:c7ca:4214:b4dd:3339:98d6:1ec0]) by smtp.gmail.com with ESMTPSA id pq8-20020a0568709c8800b000e6842a448esm3328675oab.54.2022.04.25.10.21.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 10:21:12 -0700 (PDT) Message-ID: Date: Mon, 25 Apr 2022 14:21:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] scripts/glibcelf.py: Mark as UNSUPPORTED on Python 3.5 and earlier Content-Language: en-US To: libc-alpha@sourceware.org References: <875yn1rpdy.fsf@oldenburg.str.redhat.com> <87fsm1r5ry.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87fsm1r5ry.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Apr 2022 17:21:17 -0000 On 25/04/2022 04:17, Florian Weimer via Libc-alpha wrote: > * Florian Weimer: > >> enum.IntFlag and enum.EnumMeta._missing_ support is not present in those >> Python versions. >> >> --- >> scripts/glibcelf.py | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py >> index 8f7d0ca184..da0d5380f3 100644 >> --- a/scripts/glibcelf.py >> +++ b/scripts/glibcelf.py >> @@ -28,6 +28,12 @@ import collections >> import enum >> import struct >> >> +if not hasattr(enum, 'IntFlag'): >> + import sys >> + sys.stdout.write( >> + 'warning: glibcelf.py needs Python 3.6 for enum support\n') >> + sys.exit(77) >> + >> class _OpenIntEnum(enum.IntEnum): >> """Integer enumeration that supports arbitrary int values.""" >> @classmethod > > I've pushed this, to avoid masking other failures in Joseph's tester. We still indicate that Python 3.4 is supported on INSTALL. I think we should either update it or add a fallback code on glibcelf.py.